wojtek/musichoard
1
0
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 1 Releases 4 Wiki Activity

Startup merge fails when the database has two albums with the same title as an album in the library #246

Merged
wojtek merged 11 commits from 245---startup-merge-fails-when-the-database-has-two-albums-with-the-same-title-as-an-album-in-the-library into main 2025-01-03 17:46:55 +01:00
Conversation 1 Commits 11 Files Changed 14 +476 -202
wojtek commented 2025-01-03 10:27:57 +01:00
Owner
Copy Link

Closes #245

Closes #245
wojtek added 3 commits 2025-01-03 15:49:30 +01:00
User normalised strings
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 30s
Details
Cargo CI / Lint (pull_request) Failing after 28s
Details
711e2ed2ee
wojtek added 1 commit 2025-01-03 16:34:40 +01:00
Use types to enforce normalisation
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 32s
Details
Cargo CI / Lint (pull_request) Failing after 28s
Details
7b219933c1
wojtek added 1 commit 2025-01-03 16:37:50 +01:00
aho_corasick and once_cell no longer optional
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 2m6s
Details
Cargo CI / Lint (pull_request) Successful in 1m8s
Details
4ce976739e
wojtek commented 2025-01-03 16:48:18 +01:00
Author
Owner
Copy Link

Unit tests for:

  • Two albums with same title but different MBIDs in database and one album with same title in the library
  • Multiple singletons with different album titles
  • Merge of mismatching titles, but matching when normalised
  • Multiple albums in the library with the same name and matching database entry but without lib_id yet (and vice-versa)
    • Test that it asserts only.
Unit tests for: - [x] Two albums with same title but different MBIDs in database and one album with same title in the library - [x] Multiple singletons with different album titles - [x] Merge of mismatching titles, but matching when normalised - [x] Multiple albums in the library with the same name and matching database entry but without lib_id yet (and vice-versa) - Test that it asserts only.
wojtek added 2 commits 2025-01-03 16:50:51 +01:00
Change TitleMap name
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 2m6s
Details
Cargo CI / Lint (pull_request) Successful in 1m6s
Details
e723507897
wojtek added 1 commit 2025-01-03 16:55:44 +01:00
Small fixes
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 2m6s
Details
Cargo CI / Lint (pull_request) Successful in 1m6s
Details
7cf77c74cc
wojtek added 1 commit 2025-01-03 17:21:36 +01:00
Unit tests common to artists and albums
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 2m6s
Details
Cargo CI / Lint (pull_request) Failing after 1m7s
Details
3f6364e376
wojtek added 1 commit 2025-01-03 17:37:19 +01:00
Complete unit tests
Some checks failed
Cargo CI / Build and Test (pull_request) Successful in 2m3s
Details
Cargo CI / Lint (pull_request) Failing after 1m8s
Details
ccea27531f
wojtek added 1 commit 2025-01-03 17:37:41 +01:00
Lint
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m4s
Details
Cargo CI / Lint (pull_request) Successful in 1m6s
Details
d8fdc74eba
wojtek changed title from WIP: Startup merge fails when the database has two albums with the same title as an album in the library to Startup merge fails when the database has two albums with the same title as an album in the library 2025-01-03 17:40:24 +01:00
wojtek merged commit 90c381c165 into main 2025-01-03 17:46:55 +01:00
wojtek deleted branch 245---startup-merge-fails-when-the-database-has-two-albums-with-the-same-title-as-an-album-in-the-library 2025-01-03 17:46:55 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Resolution is blocked on something external
bug
Something is not working
chore
Not an enhancement, not a bug, but needs doing
duplicate
This issue or pull request already exists
enabler
Not an enhancement, but enables an enhancement
enhancement
New feature
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wojtek/musichoard#246
No description provided.
Delete Branch "245---startup-merge-fails-when-the-database-has-two-albums-with-the-same-title-as-an-album-in-the-library"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?