wojtek/musichoard
1
0
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 1 Releases 4 Wiki Activity

Startup merge fails when the database has two albums with the same title as an album in the library #245

New Issue
Closed
opened 2025-01-03 10:22:44 +01:00 by wojtek · 6 comments
wojtek commented 2025-01-03 10:22:44 +01:00
Owner
Copy Link

Additional requirements to reproduce:

  • both database albums have an MBID
  • one of them has a lib_id which matches that of the library album
  1. First database album gets merged based on lib_id
  2. Second album tries to merge by name
  3. It finds the first, already merged, album
  4. But this album has an MBID from the merge which does not match that of the second album
Additional requirements to reproduce: - both database albums have an MBID - one of them has a lib_id which matches that of the library album 1. First database album gets merged based on lib_id 2. Second album tries to merge by name 3. It finds the first, already merged, album 4. But this album has an MBID from the merge which does not match that of the second album
wojtek added this to the v1.0.0-alpha.1 milestone 2025-01-03 10:22:44 +01:00
wojtek added the
bug
 label 2025-01-03 10:22:44 +01:00
wojtek added this to the Album tracking project 2025-01-03 10:22:44 +01:00
wojtek commented 2025-01-03 10:26:27 +01:00
Author
Owner
Copy Link

To reproduce

  1. Fetch albums of Alestorm
  2. Quit
  3. Run
To reproduce 1. Fetch albums of Alestorm 2. Quit 3. Run
wojtek added reference 245---startup-merge-fails-when-the-database-has-two-albums-with-the-same-title-as-an-album-in-the-library 2025-01-03 10:27:44 +01:00
wojtek commented 2025-01-03 10:30:17 +01:00
Author
Owner
Copy Link

In this bug-fix also consider case of the library having two albums with the same name, valid lib_ids, a matching database entry but without a lib_id yet

In this bug-fix also consider case of the library having two albums with the same name, valid lib_ids, a matching database entry but without a lib_id yet
wojtek commented 2025-01-03 11:46:39 +01:00
Author
Owner
Copy Link

Currently unhandled cases

  • Two albums with same title but different MBIDs in database and one album with same title in the library
  • Multiple singletons with different album titles
  • Multiple albums in the library with the same name and matching database entry but without lib_id yet
Currently unhandled cases - Two albums with same title but different MBIDs in database and one album with same title in the library - Multiple singletons with different album titles - Multiple albums in the library with the same name and matching database entry but without lib_id yet
wojtek commented 2025-01-03 13:12:06 +01:00
Author
Owner
Copy Link

What about title mismatch due to capitalisation and special characters?

  • Extract the normalisation method from search_state
  • In case of a miss, ensure that manually assigning an MBID will first look into DB
What about title mismatch due to capitalisation and special characters? - Extract the normalisation method from search_state - In case of a miss, ensure that manually assigning an MBID will first look into DB
wojtek commented 2025-01-03 14:40:01 +01:00
Author
Owner
Copy Link

Currently unhandled cases

  • Two albums with same title but different MBIDs in database and one album with same title in the library
  • Multiple singletons with different album titles

These should be handled with this bug fix.

  • Multiple albums in the library with the same name and matching database entry but without lib_id yet

Not fixed but asserts are placed to detect it.

> Currently unhandled cases > - Two albums with same title but different MBIDs in database and one album with same title in the library > - Multiple singletons with different album titles These should be handled with this bug fix. > - Multiple albums in the library with the same name and matching database entry but without lib_id yet Not fixed but asserts are placed to detect it.
wojtek commented 2025-01-03 14:41:20 +01:00
Author
Owner
Copy Link

What about title mismatch due to capitalisation and special characters?

  • Extract the normalisation method from search_state

Will be handled as part of this issue by normalising the titles when using them as a key.

  • In case of a miss, ensure that manually assigning an MBID will first look into DB

Create a follow up issue. A good test case for the latter is W.A.S.P. - W.A.S.P. where MB has the release group as WASP.

> What about title mismatch due to capitalisation and special characters? > - Extract the normalisation method from search_state Will be handled as part of this issue by normalising the titles when using them as a key. > - In case of a miss, ensure that manually assigning an MBID will first look into DB Create a follow up issue. A good test case for the latter is W.A.S.P. - W.A.S.P. where MB has the release group as WASP.
Sign in to join this conversation.
245---startup-merge-fails-when-the-database-has-two-albums-with-the-same-title-as-an-album-in-the-library
Branches Tags
Labels
Clear labels
blocked
Resolution is blocked on something external
bug
Something is not working
chore
Not an enhancement, not a bug, but needs doing
duplicate
This issue or pull request already exists
enabler
Not an enhancement, but enables an enhancement
enhancement
New feature
No Label
bug
Milestone
No items
No Milestone v1.0.0-alpha.1
Projects
Clear projects
No project Album tracking
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wojtek/musichoard#245
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?