wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

Add method to manually add artist metadata #85

Merged
wojtek merged 16 commits from 55---add-method-to-manually-add-artist-metadata into main 2024-01-10 22:33:58 +01:00
Conversation 1 Commits 16 Files Changed 6 +1219 -32
wojtek commented 2024-01-06 21:55:55 +01:00
Owner
Copy Link

Closes #55

Closes #55
wojtek added 5 commits 2024-01-08 22:14:58 +01:00
Add code for remaining urls
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 3m17s
Details
Cargo CI / Lint (pull_request) Successful in 42s
Details
326b876d9c
wojtek added 1 commit 2024-01-08 22:47:48 +01:00
Ignore the new binary source file
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 1m5s
Details
Cargo CI / Lint (pull_request) Successful in 42s
Details
d43f82d5ef
wojtek added 1 commit 2024-01-08 22:52:57 +01:00
Some code ergonomics
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 59s
Details
Cargo CI / Lint (pull_request) Successful in 42s
Details
ac7a86f925
wojtek added 1 commit 2024-01-09 23:45:27 +01:00
Add unit tests
Some checks failed
Cargo CI / Build and Test (pull_request) Successful in 2m25s
Details
Cargo CI / Lint (pull_request) Failing after 44s
Details
29ff4f9a00
wojtek added 1 commit 2024-01-09 23:49:54 +01:00
Fix clippy
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m1s
Details
Cargo CI / Lint (pull_request) Successful in 43s
Details
e1306e089a
wojtek commented 2024-01-09 23:52:44 +01:00
Author
Owner
Copy Link
  • Make add/remove more convenient for scripts. Adding something that exists is okay. Removing something that does not exist is okay. Remove itertools dependency if removing .format(", ").
  • Add docstring to mh-edit.
  • Use paste crate for macros https://docs.rs/paste/latest/paste/index.html.
- [x] Make add/remove more convenient for scripts. Adding something that exists is okay. Removing something that does not exist is okay. Remove itertools dependency if removing .format(", "). - [x] Add docstring to mh-edit. - [x] Use paste crate for macros https://docs.rs/paste/latest/paste/index.html.
wojtek added 1 commit 2024-01-10 09:16:28 +01:00
Do not error as much
Some checks failed
Cargo CI / Build and Test (pull_request) Successful in 2m15s
Details
Cargo CI / Lint (pull_request) Failing after 40s
Details
44675c9cbe
wojtek added 1 commit 2024-01-10 09:17:23 +01:00
Fix clippy
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m0s
Details
Cargo CI / Lint (pull_request) Successful in 42s
Details
d0e04d8a78
wojtek added 1 commit 2024-01-10 18:58:40 +01:00
Auto-generate the method identifiers
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m3s
Details
Cargo CI / Lint (pull_request) Successful in 43s
Details
f36247f53b
wojtek added 1 commit 2024-01-10 19:01:44 +01:00
Make tests consistent
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m0s
Details
Cargo CI / Lint (pull_request) Successful in 44s
Details
b35a8eea0a
wojtek added 1 commit 2024-01-10 19:30:41 +01:00
Add docstrings to the mh-edit command
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m2s
Details
Cargo CI / Lint (pull_request) Successful in 43s
Details
3a266c0ec5
wojtek changed title from WIP: Add method to manually add artist metadata to Add method to manually add artist metadata 2024-01-10 19:31:30 +01:00
wojtek added 1 commit 2024-01-10 19:34:27 +01:00
Clearer about messages
Some checks failed
Cargo CI / Build and Test (pull_request) Successful in 59s
Details
Cargo CI / Lint (pull_request) Failing after 42s
Details
b2ba9fdc4c
wojtek added 1 commit 2024-01-10 20:30:37 +01:00
Some clean up
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m3s
Details
Cargo CI / Lint (pull_request) Successful in 44s
Details
0a63ac4619
wojtek merged commit 36b82049f2 into main 2024-01-10 22:33:58 +01:00
wojtek deleted branch 55---add-method-to-manually-add-artist-metadata 2024-01-10 22:33:58 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wojtek/musichoard#85
No description provided.
Delete Branch "55---add-method-to-manually-add-artist-metadata"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?