wojtek/musichoard
1
0
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 1 Releases 4 Wiki Activity

Fetch loses albums with CannotHaveMbid as mb_ref #259

Merged
wojtek merged 3 commits from 255---fetch-loses-albums-with-cannothavembid-as-mb_ref into main 2025-01-05 14:55:36 +01:00
Conversation 0 Commits 3 Files Changed 1 +105 -73
wojtek commented 2025-01-05 13:31:52 +01:00
Owner
Copy Link

Closes #255

Closes #255
wojtek added 1 commit 2025-01-05 13:31:53 +01:00
Code fix
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m6s
Details
Cargo CI / Lint (pull_request) Successful in 1m8s
Details
6919f0214a
wojtek changed title from WIP: Fetch panics if a list shortens with a selection beyond the new length to WIP: Fetch loses albums with CannotHaveMbid as mb_ref 2025-01-05 13:55:00 +01:00
wojtek added 1 commit 2025-01-05 14:24:31 +01:00
Add unit test
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m5s
Details
Cargo CI / Lint (pull_request) Successful in 1m9s
Details
6c89131316
wojtek added 1 commit 2025-01-05 14:43:04 +01:00
Shorten code
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m3s
Details
Cargo CI / Lint (pull_request) Successful in 1m9s
Details
8b2d7fb07a
wojtek changed title from WIP: Fetch loses albums with CannotHaveMbid as mb_ref to Fetch loses albums with CannotHaveMbid as mb_ref 2025-01-05 14:43:10 +01:00
wojtek merged commit 536b3cefc8 into main 2025-01-05 14:55:36 +01:00
wojtek deleted branch 255---fetch-loses-albums-with-cannothavembid-as-mb_ref 2025-01-05 14:55:36 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Resolution is blocked on something external
bug
Something is not working
chore
Not an enhancement, not a bug, but needs doing
duplicate
This issue or pull request already exists
enabler
Not an enhancement, but enables an enhancement
enhancement
New feature
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wojtek/musichoard#259
No description provided.
Delete Branch "255---fetch-loses-albums-with-cannothavembid-as-mb_ref"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?