wojtek/musichoard
1
0
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 1 Releases 4 Wiki Activity

Ignore bootleg release groups #247

Merged
wojtek merged 10 commits from 239---ignore-bootleg-release-groups into main 2025-01-03 21:00:22 +01:00
Conversation 2 Commits 10 Files Changed 5 +128 -50
wojtek commented 2025-01-03 18:24:22 +01:00
Owner
Copy Link

Closes #239

Closes #239
wojtek added 1 commit 2025-01-03 18:24:22 +01:00
Rename AlbumStatus to AlbumOwnership
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m3s
Details
Cargo CI / Lint (pull_request) Successful in 1m6s
Details
19a3d450c1
wojtek added 1 commit 2025-01-03 18:31:53 +01:00
Fix
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m3s
Details
Cargo CI / Lint (pull_request) Successful in 1m8s
Details
dce402cee0
wojtek added 1 commit 2025-01-03 18:37:07 +01:00
Add AlbumStatus to Album
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 52s
Details
Cargo CI / Lint (pull_request) Failing after 1m6s
Details
6d1e8b88f4
wojtek commented 2025-01-03 18:37:24 +01:00
Author
Owner
Copy Link

Steps:
1. [ ] Add status to album
2. [ ] Have it written to the database
3. [ ] Add it to the UI display
4. [ ] Obtain status through MB API
5. [x] Use website default for filtering

Steps: ~~1. [ ] Add status to album~~ ~~2. [ ] Have it written to the database~~ ~~3. [ ] Add it to the UI display~~ ~~4. [ ] Obtain status through MB API~~ 5. [x] Use website default for filtering
wojtek changed title from WIP: Rename AlbumStatus to AlbumOwnership to WIP: Ignore bootleg release groups 2025-01-03 18:47:30 +01:00
wojtek added 1 commit 2025-01-03 19:03:14 +01:00
Add status to database
Some checks failed
Cargo CI / Build and Test (pull_request) Successful in 2m4s
Details
Cargo CI / Lint (pull_request) Failing after 1m8s
Details
3fb3f304ff
wojtek added 1 commit 2025-01-03 19:16:20 +01:00
Add status to display
Some checks failed
Cargo CI / Build and Test (pull_request) Successful in 2m7s
Details
Cargo CI / Lint (pull_request) Failing after 1m7s
Details
49e0b6b8f4
wojtek added 2 commits 2025-01-03 20:22:00 +01:00
Remove album status from all types
Some checks failed
Cargo CI / Lint (pull_request) Successful in 1m6s
Details
Cargo CI / Build and Test (pull_request) Failing after 54s
Details
3970271922
wojtek added 1 commit 2025-01-03 20:23:57 +01:00
Remove status from tests
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 2m2s
Details
Cargo CI / Lint (pull_request) Successful in 1m8s
Details
5e4baf7191
wojtek commented 2025-01-03 20:25:22 +01:00
Author
Owner
Copy Link

Turns out that the MB API does not return status for release groups. For example: https://musicbrainz.org/ws/2/release-group?artist=eace2373-31c8-4aba-9a5c-7bce22dd140a&release-group-status=all&limit=100. The option to filter for status probably filters the releases of a release group.

Turns out that the MB API does not return status for release groups. For example: https://musicbrainz.org/ws/2/release-group?artist=eace2373-31c8-4aba-9a5c-7bce22dd140a&release-group-status=all&limit=100. The option to filter for status probably filters the releases of a release group.
wojtek added 2 commits 2025-01-03 20:56:17 +01:00
Complete unit tests
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m7s
Details
Cargo CI / Lint (pull_request) Successful in 1m7s
Details
b84be9abcd
wojtek changed title from WIP: Ignore bootleg release groups to Ignore bootleg release groups 2025-01-03 20:56:30 +01:00
wojtek merged commit 7ebe17f0b0 into main 2025-01-03 21:00:22 +01:00
wojtek deleted branch 239---ignore-bootleg-release-groups 2025-01-03 21:00:22 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Resolution is blocked on something external
bug
Something is not working
chore
Not an enhancement, not a bug, but needs doing
duplicate
This issue or pull request already exists
enabler
Not an enhancement, but enables an enhancement
enhancement
New feature
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wojtek/musichoard#247
No description provided.
Delete Branch "239---ignore-bootleg-release-groups"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?