wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

WIP: Move coverage to cargo-llvm-cov #178

Closed
wojtek wants to merge 0 commits from 177---move-coverage-to-cargo-llvm-cov into main
pull from: 177---move-coverage-to-cargo-llvm-cov
merge into: wojtek:main
Conversation 1 Commits - Files Changed -
wojtek commented 2024-06-16 16:49:00 +02:00
Owner
Copy Link

Closes #177

Closes #177
wojtek closed this pull request 2024-06-16 17:40:06 +02:00
wojtek commented 2024-06-16 17:53:18 +02:00
Author
Owner
Copy Link

Closed because excluding code is only possible on a per-file basis. Line-based exclusion is not supported in neither llvm-cov nor rust (except on nightly). cargo-llvm-cov relies on rust's coverage feature: https://github.com/taiki-e/cargo-llvm-cov/issues/71.

Closed because excluding code is only possible on a per-file basis. Line-based exclusion is not supported in neither [llvm-cov](https://github.com/llvm/llvm-project/issues/33625) nor [rust](https://github.com/rust-lang/rust/issues/84605) (except on nightly). `cargo-llvm-cov` relies on rust's `coverage` feature: https://github.com/taiki-e/cargo-llvm-cov/issues/71.
All checks were successful
Cargo CI / Build and Test (push) Successful in 1m49s
Details
Cargo CI / Build and Test (pull_request) Successful in 1m51s
Details
Cargo CI / Lint (push) Successful in 1m5s
Details
Cargo CI / Lint (pull_request) Successful in 1m6s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wojtek/musichoard#178
No description provided.
Delete Branch "177---move-coverage-to-cargo-llvm-cov"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?