wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

Artists with a _sort field show up twice #109

Merged
wojtek merged 8 commits from 108---artists-with-a-_sort-field-show-up-twice into main 2024-01-14 15:46:34 +01:00
Conversation 2 Commits 8 Files Changed 2 +184 -81
wojtek commented 2024-01-14 00:03:19 +01:00
Owner
Copy Link

Closes #108

Closes #108
wojtek added 1 commit 2024-01-14 00:03:19 +01:00
Artists cannot be merged with MergeSorted
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 2m23s
Details
Cargo CI / Lint (pull_request) Successful in 43s
Details
bd8dd8bae5
wojtek commented 2024-01-14 00:03:23 +01:00
Author
Owner
Copy Link

Left to do:

  • Unit test to catch the bug
  • Figure out HashMap vs Vec in storage including sorting requirements
Left to do: - [x] Unit test to catch the bug - [x] Figure out HashMap vs Vec in storage including sorting requirements
wojtek added 1 commit 2024-01-14 10:17:15 +01:00
Reuse sorting methods
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 1m10s
Details
Cargo CI / Lint (pull_request) Successful in 44s
Details
67fb3fa54b
wojtek force-pushed 108---artists-with-a-_sort-field-show-up-twice from 67fb3fa54b to e9eeef94b8 2024-01-14 11:19:25 +01:00 Compare
wojtek added 2 commits 2024-01-14 14:57:35 +01:00
Convert items from library directly to hashmap
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m5s
Details
Cargo CI / Lint (pull_request) Successful in 45s
Details
639e464ff5
wojtek added 1 commit 2024-01-14 15:38:31 +01:00
Skip expensive merge for artist additon
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m4s
Details
Cargo CI / Lint (pull_request) Successful in 43s
Details
0566c3fa67
wojtek added 1 commit 2024-01-14 15:43:16 +01:00
Typo
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m3s
Details
Cargo CI / Lint (pull_request) Successful in 43s
Details
977e4e58d6
wojtek changed title from WIP: Artists cannot be merged with MergeSorted to WIP: Artists with a _sort field show up twice 2024-01-14 15:44:23 +01:00
wojtek commented 2024-01-14 15:46:15 +01:00
Author
Owner
Copy Link
  • Figure out HashMap vs Vec in storage including sorting requirements
  • Maintaining two data structures requires two edits for every modification to the library. This is burdensome and error-prone.
  • Once could wrap the contents in Rc<RefCell<Artist>>, but then users of the collection would need to .borrow() or .borrow_mut(). Since the TUI is a user of the collection that would be quite cumbersome.
> - [x] Figure out HashMap vs Vec in storage including sorting requirements - Maintaining two data structures requires two edits for every modification to the library. This is burdensome and error-prone. - Once could wrap the contents in `Rc<RefCell<Artist>>`, but then users of the collection would need to `.borrow()` or `.borrow_mut()`. Since the TUI is a user of the collection that would be quite cumbersome.
wojtek changed title from WIP: Artists with a _sort field show up twice to Artists with a _sort field show up twice 2024-01-14 15:46:26 +01:00
wojtek merged commit d876b75d14 into main 2024-01-14 15:46:34 +01:00
wojtek deleted branch 108---artists-with-a-_sort-field-show-up-twice 2024-01-14 15:46:34 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wojtek/musichoard#109
No description provided.
Delete Branch "108---artists-with-a-_sort-field-show-up-twice"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?