wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

Decide carefully where external::musicbrainz belongs #196

Merged
wojtek merged 11 commits from 193---decide-carefully-where-external--musicbrainz-belongs into main 2024-08-28 18:21:13 +02:00
Conversation 0 Commits 11 Files Changed 25 +940 -653
wojtek commented 2024-08-28 16:41:06 +02:00
Owner
Copy Link

Closes #193

Closes #193
wojtek added 8 commits 2024-08-28 16:41:06 +02:00
Split API over multiple files
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 2m41s
Details
Cargo CI / Lint (pull_request) Failing after 1m4s
Details
041a91de4c
wojtek added 2 commits 2024-08-28 18:07:18 +02:00
Finish unit tests and lints
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m58s
Details
Cargo CI / Lint (pull_request) Successful in 1m7s
Details
97e8941e90
wojtek added 1 commit 2024-08-28 18:17:59 +02:00
Minor nits
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m58s
Details
Cargo CI / Lint (pull_request) Successful in 1m5s
Details
10b5b5ebfe
wojtek changed title from WIP: Decide carefully where `external::musicbrainz` belongs to Decide carefully where `external::musicbrainz` belongs 2024-08-28 18:18:04 +02:00
wojtek merged commit 43961b3ea1 into main 2024-08-28 18:21:13 +02:00
wojtek deleted branch 193---decide-carefully-where-external--musicbrainz-belongs 2024-08-28 18:21:14 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wojtek/musichoard#196
No description provided.
Delete Branch "193---decide-carefully-where-external--musicbrainz-belongs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?