wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

Decide carefully where external::musicbrainz belongs #193

New Issue
Closed
opened 2024-08-27 14:53:28 +02:00 by wojtek · 4 comments
wojtek commented 2024-08-27 14:53:28 +02:00
Owner
Copy Link

It was originally added to lib but unlike Library and Database the MusicHoard object does not use it. Rather it is used by other components to collect information which is only then fed into MusicHoard.

It was originally added to `lib` but unlike `Library` and `Database` the `MusicHoard` object does not use it. Rather it is used by other components to collect information which is only then fed into `MusicHoard`.
wojtek added this to the v1.0.0-alpha milestone 2024-08-27 14:53:28 +02:00
wojtek added the
chore
 label 2024-08-27 14:53:28 +02:00
wojtek commented 2024-08-27 14:59:27 +02:00
Author
Owner
Copy Link

Thought: the implementation is geared specifically to how it is intended to be used by the TUI. It is not intended to be a general MB API. Therefore, it might make sense to move it entirely into the TUI crate.

Thought: the implementation is geared specifically to how it is intended to be used by the TUI. It is not intended to be a general MB API. Therefore, it might make sense to move it entirely into the TUI crate.
wojtek commented 2024-08-27 15:02:10 +02:00
Author
Owner
Copy Link

Thought 2: Refactor the lib part to be general (but only up to degree needed by TUI). TUI then makes specific calls geared towards its needs.

Thought 2: Refactor the lib part to be general (but only up to degree needed by TUI). TUI then makes specific calls geared towards its needs.
wojtek commented 2024-08-27 18:26:52 +02:00
Author
Owner
Copy Link

As part of this grep and remove all dependence on musichoard::interface::musicbrainz::* in the TUI crate.

As part of this grep and remove all dependence on `musichoard::interface::musicbrainz::*` in the TUI crate.
wojtek added this to the Album tracking project 2024-08-27 18:45:58 +02:00
wojtek commented 2024-08-27 18:49:51 +02:00
Author
Owner
Copy Link

Conclusion:

  • Make the lib component implement a plain MusicBrainz API up to the degree of flexibility is needed. Such that it could be split out into its own independent crate if desirable.
  • Migrate core::interface::musicbrainz entirely to the TUI crate.
  • The lib API implementation should not be behind a trait. That's for the user to define.
Conclusion: - Make the lib component implement a plain MusicBrainz API up to the degree of flexibility is needed. Such that it could be split out into its own independent crate if desirable. - Migrate `core::interface::musicbrainz` entirely to the TUI crate. - The lib API implementation should not be behind a trait. That's for the user to define.
wojtek added reference 193---decide-carefully-where-external--musicbrainz-belongs 2024-08-28 16:40:45 +02:00
Sign in to join this conversation.
193---decide-carefully-where-external--musicbrainz-belongs
Branches Tags
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
v1.0.0-alpha
Projects
Clear projects
No project
Album tracking
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wojtek/musichoard#193
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?