wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

Distinguish NoLibrary/NoDatabase from EmptyLibrary/EmptyDatabase #95

New Issue
Closed
opened 2024-01-12 09:35:17 +01:00 by wojtek · 2 comments
wojtek commented 2024-01-12 09:35:17 +01:00
Owner
Copy Link

There is a subtle difference between the two. EmtpyLibrary is to be used with code that expects a library, but the user does not want to provide one (e.g. using the --no-library option). NoLibrary should be used when the code does not expect a library, but the compiler requires a suitable type to be specified.

This will remove the Options fromMusicHoard.

There is a subtle difference between the two. `EmtpyLibrary` is to be used with code that expects a library, but the user does not want to provide one (e.g. using the `--no-library` option). `NoLibrary` should be used when the code does not expect a library, but the compiler requires a suitable type to be specified. This will remove the `Option`s from`MusicHoard`.
wojtek added this to the v0.2.0 milestone 2024-01-12 09:35:17 +01:00
wojtek added the
chore
 label 2024-01-12 09:35:17 +01:00
wojtek commented 2024-01-12 09:50:16 +01:00
Author
Owner
Copy Link

To do this nicely and idiomatically, this may require being specific on trait bounds in the impl of MusicHoard. This way EmptyLibrary implements ILibrary, but NoLibrary does not.

To do this nicely and idiomatically, this may require being specific on trait bounds in the `impl` of `MusicHoard`. This way `EmptyLibrary` implements `ILibrary`, but `NoLibrary` does not.
wojtek commented 2024-01-12 10:00:27 +01:00
Author
Owner
Copy Link

And provide convenience constructors to make the No/Empty variants easy to create. Probably with a builder pattern.

And provide convenience constructors to make the `No`/`Empty` variants easy to create. Probably with a builder pattern.
wojtek added reference 95---distinguish-nolibrary/nodatabase-from-emptylibrary/emptydatabase 2024-01-12 20:26:12 +01:00
Sign in to join this conversation.
95---distinguish-nolibrary/nodatabase-from-emptylibrary/emptydatabase
Branches Tags
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
v0.2.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wojtek/musichoard#95
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?