wojtek/musichoard
1
0
Fork 0
Code Issues 17 Pull Requests 1 Actions Packages Projects 1 Releases 4 Wiki Activity

Fetching and then instantly reloading library loses data #256

Merged
wojtek merged 6 commits from 254---fetching-and-then-instantly-reloading-library-loses-data into main 2025-01-05 11:06:05 +01:00
Conversation 4 Commits 6 Files Changed 8 +78 -85
wojtek commented 2025-01-04 22:46:11 +01:00
Owner
Copy Link

Closes #254

Closes #254
wojtek added 1 commit 2025-01-04 23:26:09 +01:00
Code fix
All checks were successful
Cargo CI / Lint (pull_request) Successful in 1m7s
Details
Cargo CI / Build and Test (pull_request) Successful in 2m6s
Details
ce3571e393
wojtek commented 2025-01-04 23:26:21 +01:00
Author
Owner
Copy Link

Still need some UT to test this.

Still need some UT to test this.
wojtek commented 2025-01-04 23:31:10 +01:00
Author
Owner
Copy Link

Alternative solution is to ditch the cache and always reload the database when needed. Pro: closer to actual database behaviour. Con: if #64 is implemented then this will cause additional loads over the network (though only one per lib reload).

Alternative solution is to ditch the cache and always reload the database when needed. Pro: closer to actual database behaviour. Con: if #64 is implemented then this will cause additional loads over the network (though only one per lib reload).
wojtek commented 2025-01-04 23:33:28 +01:00
Author
Owner
Copy Link

Next steps:

  1. UT this
  2. Think whether to leave this or get rid of cache.
Next steps: 1. UT this 2. Think whether to leave this or get rid of cache.
wojtek commented 2025-01-05 09:47:31 +01:00
Author
Owner
Copy Link

Cache system:

  • Pro: reduces network traffic if DB is over the network
  • Con: extra work with every DB write

Load on demand:

  • Pro: no extra work with every DB write
  • Con: extra network traffic when reloading library

Reloading library is rare. Therefore, opt for load on demand.

Cache system: - Pro: reduces network traffic if DB is over the network - Con: extra work with every DB write Load on demand: - Pro: no extra work with every DB write - Con: extra network traffic when reloading library Reloading library is rare. Therefore, opt for load on demand.
wojtek added 3 commits 2025-01-05 10:45:50 +01:00 
This reverts commit ce3571e393eeb869acdf541a1099d39524e286c1.
Make database loads explicit by the MH user
Some checks failed
Cargo CI / Build and Test (pull_request) Successful in 2m38s
Details
Cargo CI / Lint (pull_request) Failing after 1m10s
Details
180a2edd83
wojtek added 1 commit 2025-01-05 10:46:21 +01:00
Lint
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m2s
Details
Cargo CI / Lint (pull_request) Successful in 1m7s
Details
c842b1d98d
wojtek changed title from WIP: Fetching and then instantly reloading library loses data to Fetching and then instantly reloading library loses data 2025-01-05 10:48:07 +01:00
wojtek added 1 commit 2025-01-05 11:01:48 +01:00
Variable rename
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m7s
Details
Cargo CI / Lint (pull_request) Successful in 1m7s
Details
1bcd1ba1e1
wojtek merged commit ffd0d4d82f into main 2025-01-05 11:06:05 +01:00
wojtek deleted branch 254---fetching-and-then-instantly-reloading-library-loses-data 2025-01-05 11:06:05 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Resolution is blocked on something external
bug
Something is not working
chore
Not an enhancement, not a bug, but needs doing
duplicate
This issue or pull request already exists
enabler
Not an enhancement, but enables an enhancement
enhancement
New feature
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wojtek/musichoard#256
No description provided.
Delete Branch "254---fetching-and-then-instantly-reloading-library-loses-data"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?