When matching an MB entity to an owned album check if it isn't already in the collection #249

New Issue

wojtek · 2025-01-03T21:13:40+01:00

wojtek commented

2025-01-03 21:13:40 +01:00

What can happen is:

A fetch populates the collection with the albums of an artist.
The merge algorithm will do its best to match up any newly owned albums against these.
But it will fail if the album name is different in MB than in the library in a way that normalization cannot fix (e.g.: W.A.S.P. - WASP and W.A.S.P. - W.A.S.P.).
The solution is to let the next fetch merge these two items. The match part of the fetch simply needs to check if an entry with the given MBID is in the DB and remove the old entry before continuing with the merge.

This only affects albums and not artists since "unowned" artists are not fetched.

What can happen is: 1. A fetch populates the collection with the albums of an artist. 2. The merge algorithm will do its best to match up any newly owned albums against these. 3. But it will fail if the album name is different in MB than in the library in a way that normalization cannot fix (e.g.: [W.A.S.P. - WASP](https://musicbrainz.org/release-group/af1deb9c-f3c3-3624-9760-2fa791be53c7) and [W.A.S.P. - W.A.S.P.](https://madfishmusic.bandcamp.com/album/w-a-s-p-deluxe-edition)). 4. The solution is to let the next fetch merge these two items. The match part of the fetch simply needs to check if an entry with the given MBID is in the DB and remove the old entry before continuing with the merge. This only affects albums and not artists since "unowned" artists are not fetched.

wojtek added the

enhancement

label 2025-01-03 21:13:47 +01:00

wojtek added this to the v1.0.0-alpha.1 milestone 2025-01-03 21:13:49 +01:00

wojtek added this to the Album tracking project 2025-01-03 21:13:52 +01:00

wojtek added reference 249---when-matching-an-mb-entity-to-an-owned-album-check-if-it-isnt-already-in-the-collection

2025-01-03 22:10:30 +01:00

wojtek referenced a pull request that will close this issue

2025-01-03 22:10:52 +01:00

When matching an MB entity to an owned album check if it isn't already in the collection #250

wojtek closed this issue

2025-01-04 00:06:37 +01:00