wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

Remove unsafe from BeetsLibraryCommandExecutor #22

New Issue
Closed
opened 2023-04-10 21:39:43 +02:00 by wojtek · 0 comments
wojtek commented 2023-04-10 21:39:43 +02:00
Owner
Copy Link

For the same reason why File::open does not have unsafe. The behaviour is not unsafe as it does not lead to undefined behaviour within the program itself. The bug from #18 was just a typical testing bug as described in https://doc.rust-lang.org/book/ch11-02-running-tests.html#running-tests-in-parallel-or-consecutively. Correct Send and Sync behaviour is ensured by correctly using &mut self.

For the same reason why File::open does not have unsafe. The behaviour is not unsafe as it does not lead to undefined behaviour within the program itself. The bug from #18 was just a typical testing bug as described in https://doc.rust-lang.org/book/ch11-02-running-tests.html#running-tests-in-parallel-or-consecutively. Correct `Send` and `Sync` behaviour is ensured by correctly using `&mut self`.
wojtek added this to the mvp (v0.1.0) milestone 2023-04-10 21:39:43 +02:00
wojtek added the
bug
 label 2023-04-10 21:39:43 +02:00
wojtek added reference 22---remove-unsafe-from-beetslibrarycommandexecutor 2023-04-10 21:51:54 +02:00
Sign in to join this conversation.
22---remove-unsafe-from-beetslibrarycommandexecutor
Branches Tags
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
mvp (v0.1.0)
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wojtek/musichoard#22
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?