wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

Provide a keyboard shortcut to pull all release groups of an artist #160

New Issue
Open
opened 2024-03-09 18:06:18 +01:00 by wojtek · 8 comments
wojtek commented 2024-03-09 18:06:18 +01:00
Owner
Copy Link

Ensure the merge is as smooth as possible. Method for merging should be explored. Perhaps a popup window asking for manual input when it cannot be done automatically?

Goals:

  • MB ID in beets database is okay, but ultimately not really desirable. It is not a property of the music item itself.
  • Manual intervention during the merge is much more preferable than manual intervention after the merge.
Ensure the merge is as smooth as possible. Method for merging should be explored. Perhaps a popup window asking for manual input when it cannot be done automatically? Goals: * MB ID in beets database is okay, but ultimately not really desirable. It is not a property of the music item itself. * Manual intervention during the merge is much more preferable than manual intervention after the merge.
wojtek added this to the v1.0.0-alpha milestone 2024-03-09 18:06:18 +01:00
wojtek added the
enhancement
 label 2024-03-09 18:06:18 +01:00
wojtek added this to the Album tracking project 2024-03-09 18:09:20 +01:00
wojtek commented 2024-03-10 23:42:29 +01:00
Author
Owner
Copy Link

The MusicBrainz API provides a search which also includes a "score": https://musicbrainz.org/doc/MusicBrainz_API. Therefore, by searching the album title including the artist id and release date a 100 score match can be applied automatically. For the rest, a manual check can be performed. If no match is found, the album can be marked as "cannot-be-on-musicbrainz". If it is only marked as a miss, the popup may come back again next time.

The MusicBrainz API provides a search which also includes a "score": https://musicbrainz.org/doc/MusicBrainz_API. Therefore, by searching the album title including the artist id and release date a 100 score match can be applied automatically. For the rest, a manual check can be performed. If no match is found, the album can be marked as "cannot-be-on-musicbrainz". If it is only marked as a miss, the popup may come back again next time.
wojtek commented 2024-03-10 23:47:23 +01:00
Author
Owner
Copy Link

Upon calling "fetch" the logic should be to first classify the currently present albums by performing a search followed by manual selection if necessary. Only then, a fetch of the albums can happen as this way there will be an unambiguous way to match up albums.

Upon calling "fetch" the logic should be to first classify the currently present albums by performing a search followed by manual selection if necessary. Only then, a fetch of the albums can happen as this way there will be an unambiguous way to match up albums.
wojtek commented 2024-03-13 22:43:42 +01:00
Author
Owner
Copy Link

The fetch is to be implemented in #166. In this issue, the search and merge is simply always applied upon calling fetch.

The fetch is to be implemented in #166. In this issue, the search and merge is simply always applied upon calling fetch.
wojtek commented 2024-09-23 22:59:09 +02:00
Author
Owner
Copy Link

Following #185, care must be taken to correctly file release groups with multiple album artists.

Following #185, care must be taken to correctly file release groups with multiple album artists.
wojtek added reference 160---provide-a-keyboard-shortcut-to-pull-all-release-groups-of-an-artist 2024-09-29 11:46:51 +02:00
wojtek commented 2024-09-29 21:33:53 +02:00
Author
Owner
Copy Link

Part 1: #228
Part 2: #230

Part 1: #228 Part 2: #230
wojtek commented 2024-10-06 20:37:54 +02:00
Author
Owner
Copy Link

Problem: using title only for ID leads to frequent clashes of album/single/EP - need to use more information as identifier

This is tricky:

  • Intuitive solution is to move primary type to album id
  • New code is needed to update primary type
  • But updates are done by ID lookup - primary type is part of the id
  • Updating ID updates sort order

Wants

  • Having primary type affect sort order is desirable - want Albums before EPs/Singles

Challenge

  • How to handle lookups during updates (if type is None, just compare string?)

Create follow up issue.

Problem: using title only for ID leads to frequent clashes of album/single/EP - need to use more information as identifier This is tricky: - Intuitive solution is to move primary type to album id - New code is needed to update primary type - But updates are done by ID lookup - primary type is part of the id - Updating ID updates sort order Wants - Having primary type affect sort order is desirable - want Albums before EPs/Singles Challenge - How to handle lookups during updates (if type is None, just compare string?) Create follow up issue.
wojtek commented 2024-10-06 22:22:38 +02:00
Author
Owner
Copy Link

Problem: How to deal with new albums in the library? They start with no MBID. Upon inserting if AlbumId matches then just adopt the MBID. Otherwise, applying an MBID from a fetch should scan existing albums within albumartist and remove the old one.

Problem: How to deal with new albums in the library? They start with no MBID. Upon inserting if AlbumId matches then just adopt the MBID. Otherwise, applying an MBID from a fetch should scan existing albums within albumartist and remove the old one.
wojtek commented 2024-10-06 22:24:22 +02:00
Author
Owner
Copy Link

Problem: check albumartist to be applied - albums with multiple artists.

Problem: check albumartist to be applied - albums with multiple artists.
Sign in to join this conversation.
160---provide-a-keyboard-shortcut-to-pull-all-release-groups-of-an-artist
Branches Tags
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
v1.0.0-alpha
Projects
Clear projects
No project
Album tracking
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#223 Provide keyboard shortcut to fetch all artists and their release groups
wojtek/musichoard
Depends on
#166 Provide a keyboard shortcut to sync all existing albums with MusicBrainz
wojtek/musichoard
Reference: wojtek/musichoard#160
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?