wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

Streamline adding new URL types #117

New Issue
Closed
opened 2024-01-27 22:55:28 +01:00 by wojtek · 3 comments
wojtek commented 2024-01-27 22:55:28 +01:00
Owner
Copy Link

I want to add 7digital as a URL type. Currently this requires a lot of hardcoding and copying of unit tests. It would be better if adding the new URL type did not require any new code.

I want to add 7digital as a URL type. Currently this requires a lot of hardcoding and copying of unit tests. It would be better if adding the new URL type did not require any new code.
wojtek added this to the v0.2.0 milestone 2024-01-27 22:55:28 +01:00
wojtek added the
enhancement
 label 2024-01-27 22:55:28 +01:00
wojtek commented 2024-01-27 22:57:56 +01:00
Author
Owner
Copy Link

The solution will require a musichoard config of some form. And musicbrainz shall remain special due to the MBID. Perhaps reverse the relationship? MB URL derived from MBID?

The solution will require a `musichoard` config of some form. And `musicbrainz` shall remain special due to the MBID. Perhaps reverse the relationship? MB URL derived from MBID?
wojtek commented 2024-01-30 10:49:06 +01:00
Author
Owner
Copy Link

Some other thoughts:

  • Do not check URL domain - allows to implement this without any extra config
  • Do not even assume it is a URL - allows for arbitrary notes to be added
Some other thoughts: - Do not check URL domain - allows to implement this without any extra config - Do not even assume it is a URL - allows for arbitrary notes to be added
wojtek commented 2024-02-06 14:02:42 +01:00
Author
Owner
Copy Link

Leaning towards allowing arbitrary properties. That will make it easier to generalise to albums as well.

Leaning towards allowing arbitrary properties. That will make it easier to generalise to albums as well.
wojtek added reference 117---streamline-adding-new-url-types 2024-02-06 21:08:15 +01:00
Sign in to join this conversation.
117---streamline-adding-new-url-types
Branches Tags
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
v0.2.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wojtek/musichoard#117
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?