wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

Add shortcut to reload database and/or library #116

Merged
wojtek merged 14 commits from 105---add-shortcut-to-reload-database-and/or-library into main 2024-02-03 14:32:13 +01:00
Conversation 1 Commits 14 Files Changed 12 +1654 -974
wojtek commented 2024-01-24 07:55:13 +01:00
Owner
Copy Link

Closes #105

Closes #105
wojtek added 1 commit 2024-01-28 11:50:01 +01:00
Add type-based statefulness for ui
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 2m15s
Details
Cargo CI / Lint (pull_request) Failing after 43s
Details
e84aa97154
wojtek force-pushed 105---add-shortcut-to-reload-database-and/or-library from e84aa97154 to 454f9ac374 2024-01-28 12:17:59 +01:00 Compare
wojtek force-pushed 105---add-shortcut-to-reload-database-and/or-library from 454f9ac374 to 9679efefc5 2024-01-28 12:38:17 +01:00 Compare
wojtek added 1 commit 2024-01-28 19:16:00 +01:00
Working alternative type-based ui state
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 57s
Details
Cargo CI / Lint (pull_request) Failing after 42s
Details
23da0027b8
wojtek force-pushed 105---add-shortcut-to-reload-database-and/or-library from 23da0027b8 to 70ba330570 2024-01-28 19:24:58 +01:00 Compare
wojtek force-pushed 105---add-shortcut-to-reload-database-and/or-library from 70ba330570 to 665ba45a1c 2024-01-28 19:26:15 +01:00 Compare
wojtek force-pushed 105---add-shortcut-to-reload-database-and/or-library from 665ba45a1c to fdd6954ead 2024-01-28 19:32:26 +01:00 Compare
wojtek commented 2024-01-28 21:15:00 +01:00
Author
Owner
Copy Link

To do:

  • Correctly handle reloading in light of all the ways that artists/albums/tracks can be added/removed
  • When refreshing, the selection should remain in the same place as before (if possible)
To do: - [x] Correctly handle reloading in light of all the ways that artists/albums/tracks can be added/removed - [ ] When refreshing, the selection should remain in the same place as before (if possible)
wojtek added 2 commits 2024-01-28 23:35:05 +01:00
First draft of reload state
Some checks failed
Cargo CI / Build and Test (pull_request) Failing after 1m6s
Details
Cargo CI / Lint (pull_request) Failing after 43s
Details
883d6170a8
wojtek added 2 commits 2024-01-29 23:22:36 +01:00
Split ui into ui/render
Some checks failed
Cargo CI / Build and Test (pull_request) Successful in 2m26s
Details
Cargo CI / Lint (pull_request) Failing after 41s
Details
7701ce093d
wojtek added 1 commit 2024-01-31 22:28:25 +01:00
Reverse renderer/ui relationship
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m30s
Details
Cargo CI / Lint (pull_request) Successful in 44s
Details
c398cb5baa
wojtek added 1 commit 2024-01-31 23:07:33 +01:00
Remove AppError
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m3s
Details
Cargo CI / Lint (pull_request) Successful in 43s
Details
fa385fe133
wojtek force-pushed 105---add-shortcut-to-reload-database-and/or-library from fa385fe133 to 805b62e241 2024-01-31 23:10:47 +01:00 Compare
wojtek added 1 commit 2024-01-31 23:24:28 +01:00
Make error widget red
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m3s
Details
Cargo CI / Lint (pull_request) Successful in 45s
Details
00f8c4477e
wojtek added 1 commit 2024-02-01 23:08:24 +01:00
Working refresh
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m23s
Details
Cargo CI / Lint (pull_request) Successful in 44s
Details
4b9e6ff130
wojtek added 1 commit 2024-02-01 23:11:39 +01:00
Rename go_back to hide_reload_menu
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m3s
Details
Cargo CI / Lint (pull_request) Successful in 42s
Details
9ccaab563a
wojtek changed title from WIP: Add shortcut to reload database and/or library to Add shortcut to reload database and/or library 2024-02-01 23:15:04 +01:00
wojtek changed title from Add shortcut to reload database and/or library to WIP: Add shortcut to reload database and/or library 2024-02-01 23:17:45 +01:00
wojtek added 1 commit 2024-02-01 23:36:07 +01:00
Retain ListState when reinitialising
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m5s
Details
Cargo CI / Lint (pull_request) Successful in 44s
Details
272b41a6a0
wojtek changed title from WIP: Add shortcut to reload database and/or library to Add shortcut to reload database and/or library 2024-02-01 23:36:23 +01:00
wojtek added 2 commits 2024-02-03 14:28:27 +01:00
Better naming for variable in tests
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m30s
Details
Cargo CI / Lint (pull_request) Successful in 43s
Details
42c192bd01
wojtek merged commit e7413ed885 into main 2024-02-03 14:32:13 +01:00
wojtek deleted branch 105---add-shortcut-to-reload-database-and/or-library 2024-02-03 14:32:13 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wojtek/musichoard#116
No description provided.
Delete Branch "105---add-shortcut-to-reload-database-and/or-library"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?