wojtek/musichoard
1
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects 1 Releases 2 Wiki Activity

Separate the collection from beets output in tests #114

Merged
wojtek merged 8 commits from 113---separate-the-collection-from-beets-output-in-tests into main 2024-01-21 15:29:37 +01:00
Conversation 0 Commits 8 Files Changed 18 +1649 -567
wojtek commented 2024-01-14 22:03:26 +01:00
Owner
Copy Link

Closes #113

Closes #113
wojtek added 1 commit 2024-01-21 14:00:15 +01:00
Explicit test data for crate code
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 2m31s
Details
Cargo CI / Lint (pull_request) Successful in 44s
Details
290da65ca7
wojtek added 1 commit 2024-01-21 14:03:40 +01:00
Consistent naming
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m3s
Details
Cargo CI / Lint (pull_request) Successful in 43s
Details
68bb3689bd
wojtek added 1 commit 2024-01-21 14:17:20 +01:00
Correctly isolate test data
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m4s
Details
Cargo CI / Lint (pull_request) Successful in 44s
Details
c5ab724aaf
wojtek added 1 commit 2024-01-21 14:21:51 +01:00
Different naming
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m5s
Details
Cargo CI / Lint (pull_request) Successful in 44s
Details
76526ad5b9
wojtek added 1 commit 2024-01-21 14:33:48 +01:00
Don't use macros when not needed
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m2s
Details
Cargo CI / Lint (pull_request) Successful in 42s
Details
ddc212343f
wojtek added 1 commit 2024-01-21 15:08:48 +01:00
Explicit test data for integration tests as well
Some checks failed
Cargo CI / Build and Test (pull_request) Successful in 1m5s
Details
Cargo CI / Lint (pull_request) Failing after 43s
Details
7348e0d04e
wojtek added 1 commit 2024-01-21 15:13:17 +01:00
Restore albumartist_sort for paper plague
Some checks failed
Cargo CI / Build and Test (pull_request) Successful in 1m2s
Details
Cargo CI / Lint (pull_request) Failing after 43s
Details
da7926ba61
wojtek added 1 commit 2024-01-21 15:14:38 +01:00
Clippy
All checks were successful
Cargo CI / Build and Test (pull_request) Successful in 1m3s
Details
Cargo CI / Lint (pull_request) Successful in 44s
Details
73aead212c
wojtek changed title from WIP: Separate the collection from beets output in tests to Separate the collection from beets output in tests 2024-01-21 15:25:41 +01:00
wojtek force-pushed 113---separate-the-collection-from-beets-output-in-tests from 73aead212c to 8f0fd0ffb7 2024-01-21 15:27:38 +01:00 Compare
wojtek merged commit 6e9249e265 into main 2024-01-21 15:29:37 +01:00
wojtek deleted branch 113---separate-the-collection-from-beets-output-in-tests 2024-01-21 15:29:38 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Resolution is blocked on something external

  
bug

Something is not working

  
chore

Not an enhancement, not a bug, but needs doing

  
duplicate

This issue or pull request already exists

  
enabler

Not an enhancement, but enables an enhancement

  
enhancement

New feature

No Label
blocked
bug
chore
duplicate
enabler
enhancement
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: wojtek/musichoard#114
No description provided.
Delete Branch "113---separate-the-collection-from-beets-output-in-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?