Add info as substruct for Album as well

src/bin/musichoard-edit.rs

@@ -171,10 +171,7 @@ impl SortCommand {
     fn handle(self, music_hoard: &mut MH, artist_name: &str) {
         match self {
             SortCommand::Set(artist_sort_value) => music_hoard
-                .set_artist_sort(
-                    ArtistId::new(artist_name),
-                    ArtistId::new(artist_sort_value.sort),
-                )
+                .set_artist_sort(ArtistId::new(artist_name), artist_sort_value.sort)
                 .expect("faild to set artist sort name"),
             SortCommand::Clear => music_hoard
                 .clear_artist_sort(ArtistId::new(artist_name))

src/core/collection/album.rs

@@ -22,6 +22,12 @@ pub struct AlbumMeta {
     pub id: AlbumId,
     pub date: AlbumDate,
     pub seq: AlbumSeq,
+    pub info: AlbumInfo,
+}
+
+/// Album non-identifier metadata.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub struct AlbumInfo {
     pub musicbrainz: MbRefOption<MbAlbumRef>,
     pub primary_type: Option<AlbumPrimaryType>,
     pub secondary_types: Vec<AlbumSecondaryType>,
@@ -144,8 +150,9 @@ impl Album {
         primary_type: Option<AlbumPrimaryType>,
         secondary_types: Vec<AlbumSecondaryType>,
     ) -> Self {
+        let info = AlbumInfo::new(MbRefOption::None, primary_type, secondary_types);
         Album {
-            meta: AlbumMeta::new(id, date, primary_type, secondary_types),
+            meta: AlbumMeta::new(id, date, info),
             tracks: vec![],
         }
     }
@@ -179,16 +186,13 @@ impl AlbumMeta {
     pub fn new<Id: Into<AlbumId>, Date: Into<AlbumDate>>(
         id: Id,
         date: Date,
-        primary_type: Option<AlbumPrimaryType>,
-        secondary_types: Vec<AlbumSecondaryType>,
+        info: AlbumInfo,
     ) -> Self {
         AlbumMeta {
             id: id.into(),
             date: date.into(),
             seq: AlbumSeq::default(),
-            musicbrainz: MbRefOption::None,
-            primary_type,
-            secondary_types,
+            info,
         }
     }
 
@@ -203,29 +207,29 @@ impl AlbumMeta {
     pub fn clear_seq(&mut self) {
         self.seq = AlbumSeq::default();
     }
+}
 
-    pub fn set_musicbrainz_ref(&mut self, mbref: MbRefOption<MbAlbumRef>) {
-        _ = mem::replace(&mut self.musicbrainz, mbref);
+impl Default for AlbumInfo {
+    fn default() -> Self {
+        AlbumInfo {
+            musicbrainz: MbRefOption::None,
+            primary_type: None,
+            secondary_types: Vec::new(),
+        }
     }
+}
 
-    pub fn clear_musicbrainz_ref(&mut self) {
-        self.musicbrainz.take();
-    }
-
-    pub fn set_primary_type(&mut self, primary_type: Option<AlbumPrimaryType>) {
-        _ = mem::replace(&mut self.primary_type, primary_type);
-    }
-
-    pub fn clear_primary_type(&mut self) {
-        self.primary_type.take();
-    }
-
-    pub fn set_secondary_types(&mut self, secondary_types: Vec<AlbumSecondaryType>) {
-        self.secondary_types = secondary_types;
-    }
-
-    pub fn clear_secondary_types(&mut self) {
-        self.secondary_types.clear();
+impl AlbumInfo {
+    pub fn new(
+        musicbrainz: MbRefOption<MbAlbumRef>,
+        primary_type: Option<AlbumPrimaryType>,
+        secondary_types: Vec<AlbumSecondaryType>,
+    ) -> Self {
+        AlbumInfo {
+            musicbrainz,
+            primary_type,
+            secondary_types,
+        }
     }
 }
 
@@ -246,6 +250,12 @@ impl Merge for AlbumMeta {
         assert_eq!(self.id, other.id);
         self.seq = std::cmp::max(self.seq, other.seq);
 
+        self.info.merge_in_place(other.info);
+    }
+}
+
+impl Merge for AlbumInfo {
+    fn merge_in_place(&mut self, other: Self) {
         self.musicbrainz = self.musicbrainz.take().or(other.musicbrainz);
         self.primary_type = self.primary_type.take().or(other.primary_type);
         self.secondary_types.merge_in_place(other.secondary_types);
@@ -370,40 +380,4 @@ mod tests {
         let merged = left.clone().merge(right);
         assert_eq!(expected, merged);
     }
-
-    #[test]
-    fn set_clear_musicbrainz_url() {
-        const MUSICBRAINZ: &str =
-            "https://musicbrainz.org/release-group/c12897a3-af7a-3466-8892-58af84765813";
-        const MUSICBRAINZ_2: &str =
-            "https://musicbrainz.org/release-group/0eaa9306-e6df-47be-94ce-04bfe3df782c";
-
-        let mut album = Album::new(AlbumId::new("an album"), AlbumDate::default(), None, vec![]);
-
-        let mut expected: MbRefOption<MbAlbumRef> = MbRefOption::None;
-        assert_eq!(album.meta.musicbrainz, expected);
-
-        // Setting a URL on an album.
-        album.meta.set_musicbrainz_ref(MbRefOption::Some(
-            MbAlbumRef::from_url_str(MUSICBRAINZ).unwrap(),
-        ));
-        expected.replace(MbAlbumRef::from_url_str(MUSICBRAINZ).unwrap());
-        assert_eq!(album.meta.musicbrainz, expected);
-
-        album.meta.set_musicbrainz_ref(MbRefOption::Some(
-            MbAlbumRef::from_url_str(MUSICBRAINZ).unwrap(),
-        ));
-        assert_eq!(album.meta.musicbrainz, expected);
-
-        album.meta.set_musicbrainz_ref(MbRefOption::Some(
-            MbAlbumRef::from_url_str(MUSICBRAINZ_2).unwrap(),
-        ));
-        expected.replace(MbAlbumRef::from_url_str(MUSICBRAINZ_2).unwrap());
-        assert_eq!(album.meta.musicbrainz, expected);
-
-        // Clearing URLs.
-        album.meta.clear_musicbrainz_ref();
-        expected.take();
-        assert_eq!(album.meta.musicbrainz, expected);
-    }
 }

src/core/collection/artist.rs

@@ -21,7 +21,13 @@ pub struct Artist {
 #[derive(Clone, Debug, PartialEq, Eq)]
 pub struct ArtistMeta {
     pub id: ArtistId,
-    pub sort: Option<ArtistId>,
+    pub sort: Option<String>,
+    pub info: ArtistInfo,
+}
+
+/// Artist non-identifier metadata.
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub struct ArtistInfo {
     pub musicbrainz: MbRefOption<MbArtistRef>,
     pub properties: HashMap<String, Vec<String>>,
 }
@@ -75,22 +81,36 @@ impl ArtistMeta {
         ArtistMeta {
             id: id.into(),
             sort: None,
-            musicbrainz: MbRefOption::None,
-            properties: HashMap::new(),
+            info: ArtistInfo::default(),
         }
     }
 
-    pub fn get_sort_key(&self) -> (&ArtistId,) {
-        (self.sort.as_ref().unwrap_or(&self.id),)
+    pub fn get_sort_key(&self) -> (&str,) {
+        (self.sort.as_ref().unwrap_or(&self.id.name),)
     }
 
-    pub fn set_sort_key<SORT: Into<ArtistId>>(&mut self, sort: SORT) {
+    pub fn set_sort_key<S: Into<String>>(&mut self, sort: S) {
         self.sort = Some(sort.into());
     }
 
     pub fn clear_sort_key(&mut self) {
         self.sort.take();
     }
+}
+
+impl Default for ArtistInfo {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
+impl ArtistInfo {
+    pub fn new() -> Self {
+        ArtistInfo {
+            musicbrainz: MbRefOption::None,
+            properties: HashMap::new(),
+        }
+    }
 
     pub fn set_musicbrainz_ref(&mut self, mbref: MbRefOption<MbArtistRef>) {
         self.musicbrainz = mbref
@@ -162,6 +182,12 @@ impl Merge for ArtistMeta {
         assert_eq!(self.id, other.id);
 
         self.sort = self.sort.take().or(other.sort);
+        self.info.merge_in_place(other.info);
+    }
+}
+
+impl Merge for ArtistInfo {
+    fn merge_in_place(&mut self, other: Self) {
         self.musicbrainz = self.musicbrainz.take().or(other.musicbrainz);
         self.properties.merge_in_place(other.properties);
     }
@@ -207,14 +233,14 @@ mod tests {
     #[test]
     fn artist_sort_set_clear() {
         let artist_id = ArtistId::new("an artist");
-        let sort_id_1 = ArtistId::new("sort id 1");
-        let sort_id_2 = ArtistId::new("sort id 2");
+        let sort_id_1 = String::from("sort id 1");
+        let sort_id_2 = String::from("sort id 2");
 
         let mut artist = Artist::new(&artist_id.name);
 
         assert_eq!(artist.meta.id, artist_id);
         assert_eq!(artist.meta.sort, None);
-        assert_eq!(artist.meta.get_sort_key(), (&artist_id,));
+        assert_eq!(artist.meta.get_sort_key(), (artist_id.name.as_str(),));
         assert!(artist.meta < ArtistMeta::new(sort_id_1.clone()));
         assert!(artist.meta < ArtistMeta::new(sort_id_2.clone()));
         assert!(artist < Artist::new(sort_id_1.clone()));
@@ -224,7 +250,7 @@ mod tests {
 
         assert_eq!(artist.meta.id, artist_id);
         assert_eq!(artist.meta.sort.as_ref(), Some(&sort_id_1));
-        assert_eq!(artist.meta.get_sort_key(), (&sort_id_1,));
+        assert_eq!(artist.meta.get_sort_key(), (sort_id_1.as_str(),));
         assert!(artist.meta > ArtistMeta::new(artist_id.clone()));
         assert!(artist.meta < ArtistMeta::new(sort_id_2.clone()));
         assert!(artist > Artist::new(artist_id.clone()));
@@ -234,7 +260,7 @@ mod tests {
 
         assert_eq!(artist.meta.id, artist_id);
         assert_eq!(artist.meta.sort.as_ref(), Some(&sort_id_2));
-        assert_eq!(artist.meta.get_sort_key(), (&sort_id_2,));
+        assert_eq!(artist.meta.get_sort_key(), (sort_id_2.as_str(),));
         assert!(artist.meta > ArtistMeta::new(artist_id.clone()));
         assert!(artist.meta > ArtistMeta::new(sort_id_1.clone()));
         assert!(artist > Artist::new(artist_id.clone()));
@@ -244,7 +270,7 @@ mod tests {
 
         assert_eq!(artist.meta.id, artist_id);
         assert_eq!(artist.meta.sort, None);
-        assert_eq!(artist.meta.get_sort_key(), (&artist_id,));
+        assert_eq!(artist.meta.get_sort_key(), (artist_id.name.as_str(),));
         assert!(artist.meta < ArtistMeta::new(sort_id_1.clone()));
         assert!(artist.meta < ArtistMeta::new(sort_id_2.clone()));
         assert!(artist < Artist::new(sort_id_1.clone()));
@@ -256,160 +282,132 @@ mod tests {
         let mut artist = Artist::new(ArtistId::new("an artist"));
 
         let mut expected: MbRefOption<MbArtistRef> = MbRefOption::None;
-        assert_eq!(artist.meta.musicbrainz, expected);
+        assert_eq!(artist.meta.info.musicbrainz, expected);
 
         // Setting a URL on an artist.
-        artist.meta.set_musicbrainz_ref(MbRefOption::Some(
+        artist.meta.info.set_musicbrainz_ref(MbRefOption::Some(
             MbArtistRef::from_url_str(MUSICBRAINZ).unwrap(),
         ));
         expected.replace(MbArtistRef::from_url_str(MUSICBRAINZ).unwrap());
-        assert_eq!(artist.meta.musicbrainz, expected);
+        assert_eq!(artist.meta.info.musicbrainz, expected);
 
-        artist.meta.set_musicbrainz_ref(MbRefOption::Some(
+        artist.meta.info.set_musicbrainz_ref(MbRefOption::Some(
             MbArtistRef::from_url_str(MUSICBRAINZ).unwrap(),
         ));
-        assert_eq!(artist.meta.musicbrainz, expected);
+        assert_eq!(artist.meta.info.musicbrainz, expected);
 
-        artist.meta.set_musicbrainz_ref(MbRefOption::Some(
+        artist.meta.info.set_musicbrainz_ref(MbRefOption::Some(
             MbArtistRef::from_url_str(MUSICBRAINZ_2).unwrap(),
         ));
         expected.replace(MbArtistRef::from_url_str(MUSICBRAINZ_2).unwrap());
-        assert_eq!(artist.meta.musicbrainz, expected);
+        assert_eq!(artist.meta.info.musicbrainz, expected);
 
         // Clearing URLs.
-        artist.meta.clear_musicbrainz_ref();
+        artist.meta.info.clear_musicbrainz_ref();
         expected.take();
-        assert_eq!(artist.meta.musicbrainz, expected);
+        assert_eq!(artist.meta.info.musicbrainz, expected);
     }
 
     #[test]
     fn add_to_remove_from_property() {
         let mut artist = Artist::new(ArtistId::new("an artist"));
 
+        let info = &mut artist.meta.info;
         let mut expected: Vec<String> = vec![];
-        assert!(artist.meta.properties.is_empty());
+        assert!(info.properties.is_empty());
 
         // Adding a single URL.
-        artist
-            .meta
-            .add_to_property("MusicButler", vec![MUSICBUTLER]);
+        info.add_to_property("MusicButler", vec![MUSICBUTLER]);
         expected.push(MUSICBUTLER.to_owned());
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Adding a URL that already exists is ok, but does not do anything.
-        artist
-            .meta
-            .add_to_property("MusicButler", vec![MUSICBUTLER]);
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        info.add_to_property("MusicButler", vec![MUSICBUTLER]);
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Adding another single URL.
-        artist
-            .meta
-            .add_to_property("MusicButler", vec![MUSICBUTLER_2]);
+        info.add_to_property("MusicButler", vec![MUSICBUTLER_2]);
         expected.push(MUSICBUTLER_2.to_owned());
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
-        artist
-            .meta
-            .add_to_property("MusicButler", vec![MUSICBUTLER_2]);
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        info.add_to_property("MusicButler", vec![MUSICBUTLER_2]);
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Removing a URL.
-        artist
-            .meta
-            .remove_from_property("MusicButler", vec![MUSICBUTLER]);
+        info.remove_from_property("MusicButler", vec![MUSICBUTLER]);
         expected.retain(|url| url != MUSICBUTLER);
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Removing URls that do not exist is okay, they will be ignored.
-        artist
-            .meta
-            .remove_from_property("MusicButler", vec![MUSICBUTLER]);
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        info.remove_from_property("MusicButler", vec![MUSICBUTLER]);
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Removing a URL.
-        artist
-            .meta
-            .remove_from_property("MusicButler", vec![MUSICBUTLER_2]);
+        info.remove_from_property("MusicButler", vec![MUSICBUTLER_2]);
         expected.retain(|url| url.as_str() != MUSICBUTLER_2);
-        assert!(artist.meta.properties.is_empty());
+        assert!(info.properties.is_empty());
 
-        artist
-            .meta
-            .remove_from_property("MusicButler", vec![MUSICBUTLER_2]);
-        assert!(artist.meta.properties.is_empty());
+        info.remove_from_property("MusicButler", vec![MUSICBUTLER_2]);
+        assert!(info.properties.is_empty());
 
         // Adding URLs if some exist is okay, they will be ignored.
-        artist
-            .meta
-            .add_to_property("MusicButler", vec![MUSICBUTLER]);
+        info.add_to_property("MusicButler", vec![MUSICBUTLER]);
         expected.push(MUSICBUTLER.to_owned());
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
-        artist
-            .meta
-            .add_to_property("MusicButler", vec![MUSICBUTLER, MUSICBUTLER_2]);
+        info.add_to_property("MusicButler", vec![MUSICBUTLER, MUSICBUTLER_2]);
         expected.push(MUSICBUTLER_2.to_owned());
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Removing URLs if some do not exist is okay, they will be ignored.
-        artist
-            .meta
-            .remove_from_property("MusicButler", vec![MUSICBUTLER]);
+        info.remove_from_property("MusicButler", vec![MUSICBUTLER]);
         expected.retain(|url| url.as_str() != MUSICBUTLER);
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
-        artist
-            .meta
-            .remove_from_property("MusicButler", vec![MUSICBUTLER, MUSICBUTLER_2]);
+        info.remove_from_property("MusicButler", vec![MUSICBUTLER, MUSICBUTLER_2]);
         expected.retain(|url| url.as_str() != MUSICBUTLER_2);
-        assert!(artist.meta.properties.is_empty());
+        assert!(info.properties.is_empty());
 
         // Adding mutliple URLs without clashes.
-        artist
-            .meta
-            .add_to_property("MusicButler", vec![MUSICBUTLER, MUSICBUTLER_2]);
+        info.add_to_property("MusicButler", vec![MUSICBUTLER, MUSICBUTLER_2]);
         expected.push(MUSICBUTLER.to_owned());
         expected.push(MUSICBUTLER_2.to_owned());
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Removing multiple URLs without clashes.
-        artist
-            .meta
-            .remove_from_property("MusicButler", vec![MUSICBUTLER, MUSICBUTLER_2]);
+        info.remove_from_property("MusicButler", vec![MUSICBUTLER, MUSICBUTLER_2]);
         expected.clear();
-        assert!(artist.meta.properties.is_empty());
+        assert!(info.properties.is_empty());
     }
 
     #[test]
     fn set_clear_musicbutler_urls() {
         let mut artist = Artist::new(ArtistId::new("an artist"));
 
+        let info = &mut artist.meta.info;
         let mut expected: Vec<String> = vec![];
-        assert!(artist.meta.properties.is_empty());
+        assert!(info.properties.is_empty());
 
         // Set URLs.
-        artist.meta.set_property("MusicButler", vec![MUSICBUTLER]);
+        info.set_property("MusicButler", vec![MUSICBUTLER]);
         expected.push(MUSICBUTLER.to_owned());
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
-        artist.meta.set_property("MusicButler", vec![MUSICBUTLER_2]);
+        info.set_property("MusicButler", vec![MUSICBUTLER_2]);
         expected.clear();
         expected.push(MUSICBUTLER_2.to_owned());
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
-        artist
-            .meta
-            .set_property("MusicButler", vec![MUSICBUTLER, MUSICBUTLER_2]);
+        info.set_property("MusicButler", vec![MUSICBUTLER, MUSICBUTLER_2]);
         expected.clear();
         expected.push(MUSICBUTLER.to_owned());
         expected.push(MUSICBUTLER_2.to_owned());
-        assert_eq!(artist.meta.properties.get("MusicButler"), Some(&expected));
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Clear URLs.
-        artist.meta.clear_property("MusicButler");
+        info.clear_property("MusicButler");
         expected.clear();
-        assert!(artist.meta.properties.is_empty());
+        assert!(info.properties.is_empty());
     }
 
     #[test]
@@ -417,14 +415,15 @@ mod tests {
         let left = FULL_COLLECTION[0].to_owned();
         let mut right = FULL_COLLECTION[1].to_owned();
         right.meta.id = left.meta.id.clone();
-        right.meta.musicbrainz = MbRefOption::None;
-        right.meta.properties = HashMap::new();
+        right.meta.info.musicbrainz = MbRefOption::None;
+        right.meta.info.properties = HashMap::new();
 
         let mut expected = left.clone();
-        expected.meta.properties = expected
+        expected.meta.info.properties = expected
             .meta
+            .info
             .properties
-            .merge(right.clone().meta.properties);
+            .merge(right.clone().meta.info.properties);
         expected.albums.append(&mut right.albums.clone());
         expected.albums.sort_unstable();
 
@@ -445,10 +444,11 @@ mod tests {
         left.albums.sort_unstable();
 
         let mut expected = left.clone();
-        expected.meta.properties = expected
+        expected.meta.info.properties = expected
             .meta
+            .info
             .properties
-            .merge(right.clone().meta.properties);
+            .merge(right.clone().meta.info.properties);
         expected.albums.append(&mut right.albums.clone());
         expected.albums.sort_unstable();
         expected.albums.dedup();

src/core/musichoard/base.rs

@@ -97,7 +97,7 @@ impl<Database, Library> IMusicHoardBasePrivate for MusicHoard<Database, Library>
 
 #[cfg(test)]
 mod tests {
-    use crate::core::{collection::artist::ArtistId, testmod::FULL_COLLECTION};
+    use crate::core::testmod::FULL_COLLECTION;
 
     use super::*;
 
@@ -190,7 +190,7 @@ mod tests {
         let mut right: Vec<Artist> = vec![left.last().unwrap().clone()];
 
         assert!(right.first().unwrap() > left.first().unwrap());
-        let artist_sort = Some(ArtistId::new("Album_Artist 0"));
+        let artist_sort = Some(String::from("Album_Artist 0"));
         right[0].meta.sort = artist_sort.clone();
         assert!(right.first().unwrap() < left.first().unwrap());
 

src/core/musichoard/database.rs

@@ -1,13 +1,9 @@
 use crate::{
-    collection::{
-        album::{AlbumPrimaryType, AlbumSecondaryType},
-        musicbrainz::{MbAlbumRef, MbRefOption},
-    },
+    collection::{album::AlbumInfo, artist::ArtistInfo},
     core::{
         collection::{
             album::{Album, AlbumId, AlbumSeq},
             artist::{Artist, ArtistId},
-            musicbrainz::MbArtistRef,
             Collection,
         },
         interface::database::IDatabase,
@@ -21,20 +17,19 @@ pub trait IMusicHoardDatabase {
     fn add_artist<IntoId: Into<ArtistId>>(&mut self, artist_id: IntoId) -> Result<(), Error>;
     fn remove_artist<Id: AsRef<ArtistId>>(&mut self, artist_id: Id) -> Result<(), Error>;
 
-    fn set_artist_sort<Id: AsRef<ArtistId>, IntoId: Into<ArtistId>>(
+    fn set_artist_sort<Id: AsRef<ArtistId>, S: Into<String>>(
         &mut self,
         artist_id: Id,
-        artist_sort: IntoId,
+        artist_sort: S,
     ) -> Result<(), Error>;
     fn clear_artist_sort<Id: AsRef<ArtistId>>(&mut self, artist_id: Id) -> Result<(), Error>;
 
-    fn set_artist_musicbrainz<Id: AsRef<ArtistId>>(
+    fn set_artist_info<Id: AsRef<ArtistId>>(
         &mut self,
         artist_id: Id,
-        mbid: MbRefOption<MbArtistRef>,
+        info: ArtistInfo,
     ) -> Result<(), Error>;
-    fn clear_artist_musicbrainz<Id: AsRef<ArtistId>>(&mut self, artist_id: Id)
-        -> Result<(), Error>;
+    fn clear_artist_info<Id: AsRef<ArtistId>>(&mut self, artist_id: Id) -> Result<(), Error>;
 
     fn add_to_artist_property<Id: AsRef<ArtistId>, S: AsRef<str> + Into<String>>(
         &mut self,
@@ -60,17 +55,6 @@ pub trait IMusicHoardDatabase {
         property: S,
     ) -> Result<(), Error>;
 
-    fn set_album_musicbrainz<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
-        &mut self,
-        artist_id: Id,
-        album_id: AlbumIdRef,
-        mbid: MbRefOption<MbAlbumRef>,
-    ) -> Result<(), Error>;
-    fn clear_album_musicbrainz<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
-        &mut self,
-        artist_id: Id,
-        album_id: AlbumIdRef,
-    ) -> Result<(), Error>;
     fn set_album_seq<ArtistIdRef: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
         &mut self,
         artist_id: ArtistIdRef,
@@ -82,24 +66,13 @@ pub trait IMusicHoardDatabase {
         artist_id: ArtistIdRef,
         album_id: AlbumIdRef,
     ) -> Result<(), Error>;
-    fn set_album_primary_type<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
+    fn set_album_info<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
         &mut self,
         artist_id: Id,
         album_id: AlbumIdRef,
-        primary_type: Option<AlbumPrimaryType>,
+        info: AlbumInfo,
     ) -> Result<(), Error>;
-    fn clear_album_primary_type<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
-        &mut self,
-        artist_id: Id,
-        album_id: AlbumIdRef,
-    ) -> Result<(), Error>;
-    fn set_album_secondary_types<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
-        &mut self,
-        artist_id: Id,
-        album_id: AlbumIdRef,
-        secondary_types: Vec<AlbumSecondaryType>,
-    ) -> Result<(), Error>;
-    fn clear_album_secondary_types<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
+    fn clear_album_info<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
         &mut self,
         artist_id: Id,
         album_id: AlbumIdRef,
@@ -139,10 +112,10 @@ impl<Database: IDatabase, Library> IMusicHoardDatabase for MusicHoard<Database,
         })
     }
 
-    fn set_artist_sort<Id: AsRef<ArtistId>, IntoId: Into<ArtistId>>(
+    fn set_artist_sort<Id: AsRef<ArtistId>, S: Into<String>>(
         &mut self,
         artist_id: Id,
-        artist_sort: IntoId,
+        artist_sort: S,
     ) -> Result<(), Error> {
         self.update_artist_and(
             artist_id.as_ref(),
@@ -159,22 +132,17 @@ impl<Database: IDatabase, Library> IMusicHoardDatabase for MusicHoard<Database,
         )
     }
 
-    fn set_artist_musicbrainz<Id: AsRef<ArtistId>>(
+    fn set_artist_info<Id: AsRef<ArtistId>>(
         &mut self,
         artist_id: Id,
-        mbid: MbRefOption<MbArtistRef>,
+        info: ArtistInfo,
     ) -> Result<(), Error> {
-        self.update_artist(artist_id.as_ref(), |artist| {
-            artist.meta.set_musicbrainz_ref(mbid)
-        })
+        self.update_artist(artist_id.as_ref(), |artist| artist.meta.info = info)
     }
 
-    fn clear_artist_musicbrainz<Id: AsRef<ArtistId>>(
-        &mut self,
-        artist_id: Id,
-    ) -> Result<(), Error> {
+    fn clear_artist_info<Id: AsRef<ArtistId>>(&mut self, artist_id: Id) -> Result<(), Error> {
         self.update_artist(artist_id.as_ref(), |artist| {
-            artist.meta.clear_musicbrainz_ref()
+            artist.meta.info = ArtistInfo::default()
         })
     }
 
@@ -185,7 +153,7 @@ impl<Database: IDatabase, Library> IMusicHoardDatabase for MusicHoard<Database,
         values: Vec<S>,
     ) -> Result<(), Error> {
         self.update_artist(artist_id.as_ref(), |artist| {
-            artist.meta.add_to_property(property, values)
+            artist.meta.info.add_to_property(property, values)
         })
     }
 
@@ -196,7 +164,7 @@ impl<Database: IDatabase, Library> IMusicHoardDatabase for MusicHoard<Database,
         values: Vec<S>,
     ) -> Result<(), Error> {
         self.update_artist(artist_id.as_ref(), |artist| {
-            artist.meta.remove_from_property(property, values)
+            artist.meta.info.remove_from_property(property, values)
         })
     }
 
@@ -207,7 +175,7 @@ impl<Database: IDatabase, Library> IMusicHoardDatabase for MusicHoard<Database,
         values: Vec<S>,
     ) -> Result<(), Error> {
         self.update_artist(artist_id.as_ref(), |artist| {
-            artist.meta.set_property(property, values)
+            artist.meta.info.set_property(property, values)
         })
     }
 
@@ -217,28 +185,7 @@ impl<Database: IDatabase, Library> IMusicHoardDatabase for MusicHoard<Database,
         property: S,
     ) -> Result<(), Error> {
         self.update_artist(artist_id.as_ref(), |artist| {
-            artist.meta.clear_property(property)
-        })
-    }
-
-    fn set_album_musicbrainz<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
-        &mut self,
-        artist_id: Id,
-        album_id: AlbumIdRef,
-        mbid: MbRefOption<MbAlbumRef>,
-    ) -> Result<(), Error> {
-        self.update_album(artist_id.as_ref(), album_id.as_ref(), |album| {
-            album.meta.set_musicbrainz_ref(mbid)
-        })
-    }
-
-    fn clear_album_musicbrainz<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
-        &mut self,
-        artist_id: Id,
-        album_id: AlbumIdRef,
-    ) -> Result<(), Error> {
-        self.update_album(artist_id.as_ref(), album_id.as_ref(), |album| {
-            album.meta.clear_musicbrainz_ref()
+            artist.meta.info.clear_property(property)
         })
     }
 
@@ -269,45 +216,24 @@ impl<Database: IDatabase, Library> IMusicHoardDatabase for MusicHoard<Database,
         )
     }
 
-    fn set_album_primary_type<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
+    fn set_album_info<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
         &mut self,
         artist_id: Id,
         album_id: AlbumIdRef,
-        primary_type: Option<AlbumPrimaryType>,
+        info: AlbumInfo,
     ) -> Result<(), Error> {
         self.update_album(artist_id.as_ref(), album_id.as_ref(), |album| {
-            album.meta.set_primary_type(primary_type)
+            album.meta.info = info
         })
     }
 
-    fn clear_album_primary_type<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
+    fn clear_album_info<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
         &mut self,
         artist_id: Id,
         album_id: AlbumIdRef,
     ) -> Result<(), Error> {
         self.update_album(artist_id.as_ref(), album_id.as_ref(), |album| {
-            album.meta.clear_primary_type()
-        })
-    }
-
-    fn set_album_secondary_types<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
-        &mut self,
-        artist_id: Id,
-        album_id: AlbumIdRef,
-        secondary_types: Vec<AlbumSecondaryType>,
-    ) -> Result<(), Error> {
-        self.update_album(artist_id.as_ref(), album_id.as_ref(), |album| {
-            album.meta.set_secondary_types(secondary_types)
-        })
-    }
-
-    fn clear_album_secondary_types<Id: AsRef<ArtistId>, AlbumIdRef: AsRef<AlbumId>>(
-        &mut self,
-        artist_id: Id,
-        album_id: AlbumIdRef,
-    ) -> Result<(), Error> {
-        self.update_album(artist_id.as_ref(), album_id.as_ref(), |album| {
-            album.meta.clear_secondary_types()
+            album.meta.info = AlbumInfo::default()
         })
     }
 }
@@ -407,7 +333,7 @@ mod tests {
     use mockall::{predicate, Sequence};
 
     use crate::{
-        collection::musicbrainz::MbRefOption,
+        collection::musicbrainz::{MbArtistRef, MbRefOption},
         core::{
             collection::{album::AlbumDate, artist::ArtistId},
             interface::database::{self, MockIDatabase},
@@ -478,12 +404,12 @@ mod tests {
         let mut music_hoard: MH = MusicHoard::database(database).unwrap();
 
         let artist_1_id = ArtistId::new("the artist");
-        let artist_1_sort = ArtistId::new("artist, the");
+        let artist_1_sort = String::from("artist, the");
 
         // Must be after "artist, the", but before "the artist"
         let artist_2_id = ArtistId::new("b-artist");
 
-        assert!(artist_1_sort < artist_2_id);
+        assert!(artist_1_sort < artist_2_id.name);
         assert!(artist_2_id < artist_1_id);
 
         assert!(music_hoard.add_artist(artist_1_id.clone()).is_ok());
@@ -521,7 +447,7 @@ mod tests {
     }
 
     #[test]
-    fn set_clear_musicbrainz_url() {
+    fn set_clear_info() {
         let mut database = MockIDatabase::new();
         database.expect_load().times(1).returning(|| Ok(vec![]));
         database.expect_save().times(3).returning(|_| Ok(()));
@@ -533,31 +459,32 @@ mod tests {
         assert!(music_hoard.add_artist(artist_id.clone()).is_ok());
 
         let mut expected: MbRefOption<MbArtistRef> = MbRefOption::None;
-        assert_eq!(music_hoard.collection[0].meta.musicbrainz, expected);
+        assert_eq!(music_hoard.collection[0].meta.info.musicbrainz, expected);
 
-        let mbref = MbRefOption::Some(MbArtistRef::from_uuid_str(MBID).unwrap());
+        let mut info = ArtistInfo::new();
+        info.musicbrainz = MbRefOption::Some(MbArtistRef::from_uuid_str(MBID).unwrap());
 
         // Setting a URL on an artist not in the collection is an error.
         assert!(music_hoard
-            .set_artist_musicbrainz(&artist_id_2, mbref.clone())
+            .set_artist_info(&artist_id_2, info.clone())
             .is_err());
-        assert_eq!(music_hoard.collection[0].meta.musicbrainz, expected);
+        assert_eq!(music_hoard.collection[0].meta.info.musicbrainz, expected);
 
         // Setting a URL on an artist.
         assert!(music_hoard
-            .set_artist_musicbrainz(&artist_id, mbref.clone())
+            .set_artist_info(&artist_id, info.clone())
             .is_ok());
         expected.replace(MbArtistRef::from_uuid_str(MBID).unwrap());
-        assert_eq!(music_hoard.collection[0].meta.musicbrainz, expected);
+        assert_eq!(music_hoard.collection[0].meta.info.musicbrainz, expected);
 
         // Clearing URLs on an artist that does not exist is an error.
-        assert!(music_hoard.clear_artist_musicbrainz(&artist_id_2).is_err());
-        assert_eq!(music_hoard.collection[0].meta.musicbrainz, expected);
+        assert!(music_hoard.clear_artist_info(&artist_id_2).is_err());
+        assert_eq!(music_hoard.collection[0].meta.info.musicbrainz, expected);
 
         // Clearing URLs.
-        assert!(music_hoard.clear_artist_musicbrainz(&artist_id).is_ok());
+        assert!(music_hoard.clear_artist_info(&artist_id).is_ok());
         expected.take();
-        assert_eq!(music_hoard.collection[0].meta.musicbrainz, expected);
+        assert_eq!(music_hoard.collection[0].meta.info.musicbrainz, expected);
     }
 
     #[test]
@@ -573,13 +500,13 @@ mod tests {
         assert!(music_hoard.add_artist(artist_id.clone()).is_ok());
 
         let mut expected: Vec<String> = vec![];
-        assert!(music_hoard.collection[0].meta.properties.is_empty());
+        assert!(music_hoard.collection[0].meta.info.properties.is_empty());
 
         // Adding URLs to an artist not in the collection is an error.
         assert!(music_hoard
             .add_to_artist_property(&artist_id_2, "MusicButler", vec![MUSICBUTLER])
             .is_err());
-        assert!(music_hoard.collection[0].meta.properties.is_empty());
+        assert!(music_hoard.collection[0].meta.info.properties.is_empty());
 
         // Adding mutliple URLs without clashes.
         assert!(music_hoard
@@ -587,19 +514,15 @@ mod tests {
             .is_ok());
         expected.push(MUSICBUTLER.to_owned());
         expected.push(MUSICBUTLER_2.to_owned());
-        assert_eq!(
-            music_hoard.collection[0].meta.properties.get("MusicButler"),
-            Some(&expected)
-        );
+        let info = &music_hoard.collection[0].meta.info;
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Removing URLs from an artist not in the collection is an error.
         assert!(music_hoard
             .remove_from_artist_property(&artist_id_2, "MusicButler", vec![MUSICBUTLER])
             .is_err());
-        assert_eq!(
-            music_hoard.collection[0].meta.properties.get("MusicButler"),
-            Some(&expected)
-        );
+        let info = &music_hoard.collection[0].meta.info;
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Removing multiple URLs without clashes.
         assert!(music_hoard
@@ -610,7 +533,7 @@ mod tests {
             )
             .is_ok());
         expected.clear();
-        assert!(music_hoard.collection[0].meta.properties.is_empty());
+        assert!(music_hoard.collection[0].meta.info.properties.is_empty());
     }
 
     #[test]
@@ -626,13 +549,13 @@ mod tests {
         assert!(music_hoard.add_artist(artist_id.clone()).is_ok());
 
         let mut expected: Vec<String> = vec![];
-        assert!(music_hoard.collection[0].meta.properties.is_empty());
+        assert!(music_hoard.collection[0].meta.info.properties.is_empty());
 
         // Seting URL on an artist not in the collection is an error.
         assert!(music_hoard
             .set_artist_property(&artist_id_2, "MusicButler", vec![MUSICBUTLER])
             .is_err());
-        assert!(music_hoard.collection[0].meta.properties.is_empty());
+        assert!(music_hoard.collection[0].meta.info.properties.is_empty());
 
         // Set URLs.
         assert!(music_hoard
@@ -641,10 +564,8 @@ mod tests {
         expected.clear();
         expected.push(MUSICBUTLER.to_owned());
         expected.push(MUSICBUTLER_2.to_owned());
-        assert_eq!(
-            music_hoard.collection[0].meta.properties.get("MusicButler"),
-            Some(&expected)
-        );
+        let info = &music_hoard.collection[0].meta.info;
+        assert_eq!(info.properties.get("MusicButler"), Some(&expected));
 
         // Clearing URLs on an artist that does not exist is an error.
         assert!(music_hoard
@@ -656,7 +577,7 @@ mod tests {
             .clear_artist_property(&artist_id, "MusicButler")
             .is_ok());
         expected.clear();
-        assert!(music_hoard.collection[0].meta.properties.is_empty());
+        assert!(music_hoard.collection[0].meta.info.properties.is_empty());
     }
 
     #[test]

src/core/musichoard/library.rs

@@ -52,7 +52,7 @@ impl<Database, Library: ILibrary> MusicHoard<Database, Library> {
                 name: item.album_artist,
             };
 
-            let artist_sort = item.album_artist_sort.map(|s| ArtistId { name: s });
+            let artist_sort = item.album_artist_sort;
 
             let album_id = AlbumId {
                 title: item.album_title,

src/core/testmod.rs

@@ -2,8 +2,8 @@ use once_cell::sync::Lazy;
 use std::collections::HashMap;
 
 use crate::core::collection::{
-    album::{Album, AlbumId, AlbumMeta, AlbumPrimaryType, AlbumSeq},
-    artist::{Artist, ArtistId, ArtistMeta},
+    album::{Album, AlbumId, AlbumInfo, AlbumMeta, AlbumPrimaryType, AlbumSeq},
+    artist::{Artist, ArtistId, ArtistInfo, ArtistMeta},
     musicbrainz::{MbAlbumRef, MbArtistRef, MbRefOption},
     track::{Track, TrackFormat, TrackId, TrackNum, TrackQuality},
 };

src/external/database/serde/deserialize.rs

@@ -4,8 +4,8 @@ use serde::{de::Visitor, Deserialize, Deserializer};
 
 use crate::{
     collection::{
-        album::AlbumMeta,
-        artist::ArtistMeta,
+        album::{AlbumInfo, AlbumMeta},
+        artist::{ArtistInfo, ArtistMeta},
         musicbrainz::{MbAlbumRef, MbArtistRef, MbRefOption, Mbid},
     },
     core::collection::{
@@ -114,9 +114,11 @@ impl From<DeserializeArtist> for Artist {
         Artist {
             meta: ArtistMeta {
                 id: ArtistId::new(artist.name),
-                sort: artist.sort.map(ArtistId::new),
-                musicbrainz: artist.musicbrainz.into(),
-                properties: artist.properties,
+                sort: artist.sort,
+                info: ArtistInfo {
+                    musicbrainz: artist.musicbrainz.into(),
+                    properties: artist.properties,
+                },
             },
             albums: artist.albums.into_iter().map(Into::into).collect(),
         }
@@ -130,9 +132,11 @@ impl From<DeserializeAlbum> for Album {
                 id: AlbumId { title: album.title },
                 date: AlbumDate::default(),
                 seq: AlbumSeq(album.seq),
-                musicbrainz: album.musicbrainz.into(),
-                primary_type: album.primary_type.map(Into::into),
-                secondary_types: album.secondary_types.into_iter().map(Into::into).collect(),
+                info: AlbumInfo {
+                    musicbrainz: album.musicbrainz.into(),
+                    primary_type: album.primary_type.map(Into::into),
+                    secondary_types: album.secondary_types.into_iter().map(Into::into).collect(),
+                },
             },
             tracks: vec![],
         }

src/external/database/serde/serialize.rs

@@ -72,10 +72,11 @@ impl<'a> From<&'a Artist> for SerializeArtist<'a> {
     fn from(artist: &'a Artist) -> Self {
         SerializeArtist {
             name: &artist.meta.id.name,
-            sort: artist.meta.sort.as_ref().map(|id| id.name.as_ref()),
-            musicbrainz: (&artist.meta.musicbrainz).into(),
+            sort: artist.meta.sort.as_deref(),
+            musicbrainz: (&artist.meta.info.musicbrainz).into(),
             properties: artist
                 .meta
+                .info
                 .properties
                 .iter()
                 .map(|(k, v)| (k.as_ref(), v))
@@ -90,10 +91,11 @@ impl<'a> From<&'a Album> for SerializeAlbum<'a> {
         SerializeAlbum {
             title: &album.meta.id.title,
             seq: album.meta.seq.0,
-            musicbrainz: (&album.meta.musicbrainz).into(),
-            primary_type: album.meta.primary_type.map(Into::into),
+            musicbrainz: (&album.meta.info.musicbrainz).into(),
+            primary_type: album.meta.info.primary_type.map(Into::into),
             secondary_types: album
                 .meta
+                .info
                 .secondary_types
                 .iter()
                 .copied()

src/external/musicbrainz/api/mod.rs

@@ -4,8 +4,7 @@ use serde::{de::Visitor, Deserialize, Deserializer};
 
 use crate::{
     collection::{
-        album::{AlbumDate, AlbumId, AlbumPrimaryType, AlbumSecondaryType},
-        artist::ArtistId,
+        album::{AlbumDate, AlbumPrimaryType, AlbumSecondaryType},
         musicbrainz::Mbid,
         Error as CollectionError,
     },
@@ -62,8 +61,8 @@ impl<Http> MusicBrainzClient<Http> {
 #[derive(Clone, Debug, PartialEq, Eq)]
 pub struct MbArtistMeta {
     pub id: Mbid,
-    pub name: ArtistId,
-    pub sort_name: ArtistId,
+    pub name: String,
+    pub sort_name: String,
     pub disambiguation: Option<String>,
 }
 
@@ -80,8 +79,8 @@ impl From<SerdeMbArtistMeta> for MbArtistMeta {
     fn from(value: SerdeMbArtistMeta) -> Self {
         MbArtistMeta {
             id: value.id.into(),
-            name: value.name.into(),
-            sort_name: value.sort_name.into(),
+            name: value.name,
+            sort_name: value.sort_name,
             disambiguation: value.disambiguation,
         }
     }
@@ -90,7 +89,7 @@ impl From<SerdeMbArtistMeta> for MbArtistMeta {
 #[derive(Clone, Debug, PartialEq, Eq)]
 pub struct MbReleaseGroupMeta {
     pub id: Mbid,
-    pub title: AlbumId,
+    pub title: String,
     pub first_release_date: AlbumDate,
     pub primary_type: AlbumPrimaryType,
     pub secondary_types: Option<Vec<AlbumSecondaryType>>,
@@ -110,7 +109,7 @@ impl From<SerdeMbReleaseGroupMeta> for MbReleaseGroupMeta {
     fn from(value: SerdeMbReleaseGroupMeta) -> Self {
         MbReleaseGroupMeta {
             id: value.id.into(),
-            title: value.title.into(),
+            title: value.title,
             first_release_date: value.first_release_date.into(),
             primary_type: value.primary_type.into(),
             secondary_types: value

src/testmod/full.rs

@@ -7,19 +7,21 @@ macro_rules! full_collection {
                         name: "Album_Artist ‘A’".to_string(),
                     },
                     sort: None,
-                    musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
-                        "https://musicbrainz.org/artist/00000000-0000-0000-0000-000000000000"
-                    ).unwrap()),
-                    properties: HashMap::from([
-                        (String::from("MusicButler"), vec![
-                            String::from("https://www.musicbutler.io/artist-page/000000000"),
+                    info: ArtistInfo {
+                        musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
+                            "https://musicbrainz.org/artist/00000000-0000-0000-0000-000000000000"
+                        ).unwrap()),
+                        properties: HashMap::from([
+                            (String::from("MusicButler"), vec![
+                                String::from("https://www.musicbutler.io/artist-page/000000000"),
+                            ]),
+                            (String::from("Qobuz"), vec![
+                                String::from(
+                                    "https://www.qobuz.com/nl-nl/interpreter/artist-a/download-streaming-albums",
+                                )
+                            ]),
                         ]),
-                        (String::from("Qobuz"), vec![
-                            String::from(
-                                "https://www.qobuz.com/nl-nl/interpreter/artist-a/download-streaming-albums",
-                            )
-                        ]),
-                    ]),
+                    },
                 },
                 albums: vec![
                     Album {
@@ -29,11 +31,13 @@ macro_rules! full_collection {
                             },
                             date: 1998.into(),
                             seq: AlbumSeq(1),
-                            musicbrainz: MbRefOption::Some(MbAlbumRef::from_url_str(
-                                "https://musicbrainz.org/release-group/00000000-0000-0000-0000-000000000000"
-                            ).unwrap()),
-                            primary_type: Some(AlbumPrimaryType::Album),
-                            secondary_types: vec![],
+                            info: AlbumInfo {
+                                musicbrainz: MbRefOption::Some(MbAlbumRef::from_url_str(
+                                    "https://musicbrainz.org/release-group/00000000-0000-0000-0000-000000000000"
+                                ).unwrap()),
+                                primary_type: Some(AlbumPrimaryType::Album),
+                                secondary_types: vec![],
+                            },
                         },
                         tracks: vec![
                             Track {
@@ -92,9 +96,11 @@ macro_rules! full_collection {
                             },
                             date: (2015, 4).into(),
                             seq: AlbumSeq(1),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: Some(AlbumPrimaryType::Album),
-                            secondary_types: vec![],
+                            info: AlbumInfo {
+                                musicbrainz: MbRefOption::None,
+                                primary_type: Some(AlbumPrimaryType::Album),
+                                secondary_types: vec![],
+                            },
                         },
                         tracks: vec![
                             Track {
@@ -129,23 +135,25 @@ macro_rules! full_collection {
                         name: "Album_Artist ‘B’".to_string(),
                     },
                     sort: None,
-                    musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
-                        "https://musicbrainz.org/artist/11111111-1111-1111-1111-111111111111"
-                    ).unwrap()),
-                    properties: HashMap::from([
-                        (String::from("MusicButler"), vec![
-                            String::from("https://www.musicbutler.io/artist-page/111111111"),
-                            String::from("https://www.musicbutler.io/artist-page/111111112"),
+                    info: ArtistInfo {
+                        musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
+                            "https://musicbrainz.org/artist/11111111-1111-1111-1111-111111111111"
+                        ).unwrap()),
+                        properties: HashMap::from([
+                            (String::from("MusicButler"), vec![
+                                String::from("https://www.musicbutler.io/artist-page/111111111"),
+                                String::from("https://www.musicbutler.io/artist-page/111111112"),
+                            ]),
+                            (String::from("Bandcamp"), vec![
+                                String::from("https://artist-b.bandcamp.com/")
+                            ]),
+                            (String::from("Qobuz"), vec![
+                                String::from(
+                                    "https://www.qobuz.com/nl-nl/interpreter/artist-b/download-streaming-albums",
+                                )
+                            ]),
                         ]),
-                        (String::from("Bandcamp"), vec![
-                            String::from("https://artist-b.bandcamp.com/")
-                        ]),
-                        (String::from("Qobuz"), vec![
-                            String::from(
-                                "https://www.qobuz.com/nl-nl/interpreter/artist-b/download-streaming-albums",
-                            )
-                        ]),
-                    ]),
+                    },
                 },
                 albums: vec![
                     Album {
@@ -155,9 +163,11 @@ macro_rules! full_collection {
                             },
                             date: (2003, 6, 6).into(),
                             seq: AlbumSeq(1),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: Some(AlbumPrimaryType::Album),
-                            secondary_types: vec![],
+                            info: AlbumInfo {
+                                musicbrainz: MbRefOption::None,
+                                primary_type: Some(AlbumPrimaryType::Album),
+                                secondary_types: vec![],
+                            },
                         },
                         tracks: vec![
                             Track {
@@ -194,11 +204,13 @@ macro_rules! full_collection {
                             },
                             date: 2008.into(),
                             seq: AlbumSeq(3),
-                            musicbrainz: MbRefOption::Some(MbAlbumRef::from_url_str(
-                                "https://musicbrainz.org/release-group/11111111-1111-1111-1111-111111111111"
-                            ).unwrap()),
-                            primary_type: Some(AlbumPrimaryType::Album),
-                            secondary_types: vec![],
+                            info: AlbumInfo {
+                                musicbrainz: MbRefOption::Some(MbAlbumRef::from_url_str(
+                                    "https://musicbrainz.org/release-group/11111111-1111-1111-1111-111111111111"
+                                ).unwrap()),
+                                primary_type: Some(AlbumPrimaryType::Album),
+                                secondary_types: vec![],
+                            },
                         },
                         tracks: vec![
                             Track {
@@ -235,11 +247,13 @@ macro_rules! full_collection {
                             },
                             date: 2009.into(),
                             seq: AlbumSeq(2),
-                            musicbrainz: MbRefOption::Some(MbAlbumRef::from_url_str(
-                                "https://musicbrainz.org/release-group/11111111-1111-1111-1111-111111111112"
-                            ).unwrap()),
-                            primary_type: Some(AlbumPrimaryType::Album),
-                            secondary_types: vec![],
+                            info: AlbumInfo {
+                                musicbrainz: MbRefOption::Some(MbAlbumRef::from_url_str(
+                                    "https://musicbrainz.org/release-group/11111111-1111-1111-1111-111111111112"
+                                ).unwrap()),
+                                primary_type: Some(AlbumPrimaryType::Album),
+                                secondary_types: vec![],
+                            },
                         },
                         tracks: vec![
                             Track {
@@ -276,9 +290,11 @@ macro_rules! full_collection {
                             },
                             date: 2015.into(),
                             seq: AlbumSeq(4),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: Some(AlbumPrimaryType::Album),
-                            secondary_types: vec![],
+                            info: AlbumInfo {
+                                musicbrainz: MbRefOption::None,
+                                primary_type: Some(AlbumPrimaryType::Album),
+                                secondary_types: vec![],
+                            },
                         },
                         tracks: vec![
                             Track {
@@ -315,11 +331,11 @@ macro_rules! full_collection {
                     id: ArtistId {
                         name: "The Album_Artist ‘C’".to_string(),
                     },
-                    sort: Some(ArtistId {
-                        name: "Album_Artist ‘C’, The".to_string(),
-                    }),
-                    musicbrainz: MbRefOption::CannotHaveMbid,
-                    properties: HashMap::new(),
+                    sort: Some("Album_Artist ‘C’, The".to_string()),
+                    info: ArtistInfo {
+                        musicbrainz: MbRefOption::CannotHaveMbid,
+                        properties: HashMap::new(),
+                    },
                 },
                 albums: vec![
                     Album {
@@ -329,9 +345,11 @@ macro_rules! full_collection {
                             },
                             date: 1985.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: Some(AlbumPrimaryType::Album),
-                            secondary_types: vec![],
+                            info: AlbumInfo {
+                                musicbrainz: MbRefOption::None,
+                                primary_type: Some(AlbumPrimaryType::Album),
+                                secondary_types: vec![],
+                            },
                         },
                         tracks: vec![
                             Track {
@@ -368,9 +386,11 @@ macro_rules! full_collection {
                             },
                             date: 2018.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: Some(AlbumPrimaryType::Album),
-                            secondary_types: vec![],
+                            info: AlbumInfo {
+                                musicbrainz: MbRefOption::None,
+                                primary_type: Some(AlbumPrimaryType::Album),
+                                secondary_types: vec![],
+                            },
                         },
                         tracks: vec![
                             Track {
@@ -408,8 +428,10 @@ macro_rules! full_collection {
                         name: "Album_Artist ‘D’".to_string(),
                     },
                     sort: None,
-                    musicbrainz: MbRefOption::None,
-                    properties: HashMap::new(),
+                    info: ArtistInfo {
+                        musicbrainz: MbRefOption::None,
+                        properties: HashMap::new(),
+                    },
                 },
                 albums: vec![
                     Album {
@@ -419,9 +441,11 @@ macro_rules! full_collection {
                             },
                             date: 1995.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: Some(AlbumPrimaryType::Album),
-                            secondary_types: vec![],
+                            info: AlbumInfo {
+                                musicbrainz: MbRefOption::None,
+                                primary_type: Some(AlbumPrimaryType::Album),
+                                secondary_types: vec![],
+                            },
                         },
                         tracks: vec![
                             Track {
@@ -458,9 +482,11 @@ macro_rules! full_collection {
                             },
                             date: 2028.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: Some(AlbumPrimaryType::Album),
-                            secondary_types: vec![],
+                            info: AlbumInfo {
+                                musicbrainz: MbRefOption::None,
+                                primary_type: Some(AlbumPrimaryType::Album),
+                                secondary_types: vec![],
+                            },
                         },
                         tracks: vec![
                             Track {

src/testmod/library.rs

@@ -8,8 +8,10 @@ macro_rules! library_collection {
                         name: "Album_Artist ‘A’".to_string(),
                     },
                     sort: None,
-                    musicbrainz: MbRefOption::None,
-                    properties: HashMap::new(),
+                    info: ArtistInfo {
+                        musicbrainz: MbRefOption::None,
+                        properties: HashMap::new(),
+                    },
                 },
                 albums: vec![
                     Album {
@@ -19,9 +21,7 @@ macro_rules! library_collection {
                             },
                             date: 1998.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: None,
-                            secondary_types: vec![],
+                            info: AlbumInfo::default(),
                         },
                         tracks: vec![
                             Track {
@@ -80,9 +80,7 @@ macro_rules! library_collection {
                             },
                             date: (2015, 4).into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: None,
-                            secondary_types: vec![],
+                            info: AlbumInfo::default(),
                         },
                         tracks: vec![
                             Track {
@@ -117,8 +115,10 @@ macro_rules! library_collection {
                         name: "Album_Artist ‘B’".to_string(),
                     },
                     sort: None,
-                    musicbrainz: MbRefOption::None,
-                    properties: HashMap::new(),
+                    info: ArtistInfo {
+                        musicbrainz: MbRefOption::None,
+                        properties: HashMap::new(),
+                    },
                 },
                 albums: vec![
                     Album {
@@ -128,9 +128,7 @@ macro_rules! library_collection {
                             },
                             date: (2003, 6, 6).into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: None,
-                            secondary_types: vec![],
+                            info: AlbumInfo::default(),
                         },
                         tracks: vec![
                             Track {
@@ -167,9 +165,7 @@ macro_rules! library_collection {
                             },
                             date: 2008.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: None,
-                            secondary_types: vec![],
+                            info: AlbumInfo::default(),
                         },
                         tracks: vec![
                             Track {
@@ -206,9 +202,7 @@ macro_rules! library_collection {
                             },
                             date: 2009.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: None,
-                            secondary_types: vec![],
+                            info: AlbumInfo::default(),
                         },
                         tracks: vec![
                             Track {
@@ -245,9 +239,7 @@ macro_rules! library_collection {
                             },
                             date: 2015.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: None,
-                            secondary_types: vec![],
+                            info: AlbumInfo::default(),
                         },
                         tracks: vec![
                             Track {
@@ -284,11 +276,11 @@ macro_rules! library_collection {
                     id: ArtistId {
                         name: "The Album_Artist ‘C’".to_string(),
                     },
-                    sort: Some(ArtistId {
-                        name: "Album_Artist ‘C’, The".to_string(),
-                    }),
-                    musicbrainz: MbRefOption::None,
-                    properties: HashMap::new(),
+                    sort: Some("Album_Artist ‘C’, The".to_string()),
+                    info: ArtistInfo {
+                        musicbrainz: MbRefOption::None,
+                        properties: HashMap::new(),
+                    },
                 },
                 albums: vec![
                     Album {
@@ -298,9 +290,7 @@ macro_rules! library_collection {
                             },
                             date: 1985.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: None,
-                            secondary_types: vec![],
+                            info: AlbumInfo::default(),
                         },
                         tracks: vec![
                             Track {
@@ -337,9 +327,7 @@ macro_rules! library_collection {
                             },
                             date: 2018.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: None,
-                            secondary_types: vec![],
+                            info: AlbumInfo::default(),
                         },
                         tracks: vec![
                             Track {
@@ -377,8 +365,10 @@ macro_rules! library_collection {
                         name: "Album_Artist ‘D’".to_string(),
                     },
                     sort: None,
-                    musicbrainz: MbRefOption::None,
-                    properties: HashMap::new(),
+                    info: ArtistInfo {
+                        musicbrainz: MbRefOption::None,
+                        properties: HashMap::new(),
+                    },
                 },
                 albums: vec![
                     Album {
@@ -388,9 +378,7 @@ macro_rules! library_collection {
                             },
                             date: 1995.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: None,
-                            secondary_types: vec![],
+                            info: AlbumInfo::default(),
                         },
                         tracks: vec![
                             Track {
@@ -427,9 +415,7 @@ macro_rules! library_collection {
                             },
                             date: 2028.into(),
                             seq: AlbumSeq(0),
-                            musicbrainz: MbRefOption::None,
-                            primary_type: None,
-                            secondary_types: vec![],
+                            info: AlbumInfo::default(),
                         },
                         tracks: vec![
                             Track {

src/tui/app/machine/fetch_state.rs

@@ -156,12 +156,12 @@ impl AppMachine<FetchState> {
         result_sender: ResultSender,
         artist: &Artist,
     ) -> Result<(), FetchError> {
-        let requests = match artist.meta.musicbrainz {
+        let requests = match artist.meta.info.musicbrainz {
             MbRefOption::Some(ref arid) => {
                 let arid = arid.mbid();
                 let albums = artist.albums.iter();
                 albums
-                    .filter(|album| matches!(album.meta.musicbrainz, MbRefOption::None))
+                    .filter(|album| matches!(album.meta.info.musicbrainz, MbRefOption::None))
                     .map(|album| {
                         MbParams::search_release_group(
                             artist.meta.id.clone(),

src/tui/app/machine/match_state.rs

@@ -26,12 +26,13 @@ macro_rules! item_option_artist_set {
                 music_hoard: &mut dyn IMusicHoard,
                 meta: &ArtistMeta,
             ) -> Result<(), musichoard::Error> {
-                let mbref = match self {
-                    MatchOption::Some(m) => m.item.musicbrainz,
+                let mut info = meta.info.clone();
+                info.musicbrainz = match self {
+                    MatchOption::Some(m) => m.item.info.musicbrainz,
                     MatchOption::CannotHaveMbid => MbRefOption::CannotHaveMbid,
                     MatchOption::ManualInputMbid => panic!(),
                 };
-                music_hoard.set_artist_musicbrainz(&meta.id, mbref)
+                music_hoard.set_artist_info(&meta.id, info)
             }
         }
     };
@@ -49,19 +50,17 @@ macro_rules! item_option_album_set {
                 artist: &ArtistId,
                 meta: &AlbumMeta,
             ) -> Result<(), musichoard::Error> {
-                let (mbref, primary_type, secondary_types) = match self {
+                let mut info = meta.info.clone();
+                (info.musicbrainz, info.primary_type, info.secondary_types) = match self {
                     MatchOption::Some(m) => (
-                        m.item.musicbrainz,
-                        m.item.primary_type,
-                        m.item.secondary_types,
+                        m.item.info.musicbrainz,
+                        m.item.info.primary_type,
+                        m.item.info.secondary_types,
                     ),
                     MatchOption::CannotHaveMbid => (MbRefOption::CannotHaveMbid, None, Vec::new()),
                     MatchOption::ManualInputMbid => panic!(),
                 };
-                music_hoard.set_album_musicbrainz(artist, &meta.id, mbref)?;
-                music_hoard.set_album_primary_type(artist, &meta.id, primary_type)?;
-                music_hoard.set_album_secondary_types(artist, &meta.id, secondary_types)?;
-                Ok(())
+                music_hoard.set_album_info(artist, &meta.id, info)
             }
         }
     };
@@ -343,7 +342,7 @@ mod tests {
 
     use mockall::predicate;
     use musichoard::collection::{
-        album::{AlbumDate, AlbumId, AlbumMeta, AlbumPrimaryType, AlbumSecondaryType},
+        album::{AlbumDate, AlbumId, AlbumInfo, AlbumMeta, AlbumPrimaryType, AlbumSecondaryType},
         artist::{ArtistId, ArtistMeta},
     };
 
@@ -404,8 +403,11 @@ mod tests {
         let album = AlbumMeta::new(
             AlbumId::new("Album"),
             AlbumDate::new(Some(1990), Some(5), None),
-            Some(AlbumPrimaryType::Album),
-            vec![AlbumSecondaryType::Live, AlbumSecondaryType::Compilation],
+            AlbumInfo::new(
+                MbRefOption::None,
+                Some(AlbumPrimaryType::Album),
+                vec![AlbumSecondaryType::Live, AlbumSecondaryType::Compilation],
+            ),
         );
 
         let album_1 = album.clone();
@@ -413,7 +415,7 @@ mod tests {
 
         let mut album_2 = album.clone();
         album_2.id.title.push_str(" extra title part");
-        album_2.secondary_types.pop();
+        album_2.info.secondary_types.pop();
         let album_match_2 = Match::new(100, album_2);
 
         let list = vec![album_match_1.clone(), album_match_2.clone()];
@@ -425,8 +427,11 @@ mod tests {
         let album = AlbumMeta::new(
             AlbumId::new("Album"),
             AlbumDate::new(Some(1990), Some(5), None),
-            Some(AlbumPrimaryType::Album),
-            vec![AlbumSecondaryType::Live, AlbumSecondaryType::Compilation],
+            AlbumInfo::new(
+                MbRefOption::None,
+                Some(AlbumPrimaryType::Album),
+                vec![AlbumSecondaryType::Live, AlbumSecondaryType::Compilation],
+            ),
         );
         let lookup = Lookup::new(album.clone());
         MatchStateInfo::album_lookup(artist_id, album, lookup)
@@ -642,7 +647,7 @@ mod tests {
     fn select_manual_input_album() {
         let mut mb_job_sender = MockIMbJobSender::new();
         let artist_id = ArtistId::new("Artist");
-        let album = AlbumMeta::new("Album", 1990, None, vec![]);
+        let album = AlbumMeta::new("Album", 1990, AlbumInfo::default());
         let requests = VecDeque::from([MbParams::lookup_release_group(
             artist_id.clone(),
             album.clone(),

src/tui/app/machine/search_state.rs

@@ -182,7 +182,7 @@ impl IAppInteractSearchPrivate for AppMachine<SearchState> {
 
         if let Some(ref probe_sort) = probe.meta.sort {
             if !result {
-                let name = Self::normalize_search(&probe_sort.name, !case_sens, !char_sens);
+                let name = Self::normalize_search(probe_sort, !case_sens, !char_sens);
                 result = name.starts_with(search);
             }
         }

src/tui/app/selection/artist.rs

@@ -205,14 +205,14 @@ impl KeySelectArtist {
             let artist = &artists[index];
             let key = artist.meta.get_sort_key();
             KeySelectArtist {
-                key: (key.0.to_owned(),),
+                key: (key.0.into(),),
                 album: KeySelectAlbum::get(&artist.albums, &selection.album),
             }
         })
     }
 
-    pub fn get_sort_key(&self) -> (&ArtistId,) {
-        (&self.key.0,)
+    pub fn get_sort_key(&self) -> (&str,) {
+        (&self.key.0.name,)
     }
 }
 

src/tui/lib/external/musicbrainz/api/mod.rs

@@ -4,8 +4,8 @@ use std::collections::HashMap;
 
 use musichoard::{
     collection::{
-        album::{AlbumDate, AlbumMeta, AlbumSeq},
-        artist::{ArtistId, ArtistMeta},
+        album::{AlbumDate, AlbumInfo, AlbumMeta, AlbumSeq},
+        artist::{ArtistInfo, ArtistMeta},
         musicbrainz::{MbRefOption, Mbid},
     },
     external::musicbrainz::{
@@ -93,15 +93,15 @@ impl<Http: IMusicBrainzHttp> IMusicBrainz for MusicBrainz<Http> {
 }
 
 fn from_lookup_artist_response(entity: LookupArtistResponse) -> Lookup<ArtistMeta> {
-    let sort: Option<ArtistId> = Some(entity.meta.sort_name)
-        .filter(|s| s != &entity.meta.name)
-        .map(Into::into);
+    let sort = Some(entity.meta.sort_name).filter(|s| s != &entity.meta.name);
     Lookup {
         item: ArtistMeta {
-            id: entity.meta.name,
+            id: entity.meta.name.into(),
             sort,
-            musicbrainz: MbRefOption::Some(entity.meta.id.into()),
-            properties: HashMap::new(),
+            info: ArtistInfo {
+                musicbrainz: MbRefOption::Some(entity.meta.id.into()),
+                properties: HashMap::new(),
+            },
         },
         disambiguation: entity.meta.disambiguation,
     }
@@ -110,28 +110,30 @@ fn from_lookup_artist_response(entity: LookupArtistResponse) -> Lookup<ArtistMet
 fn from_lookup_release_group_response(entity: LookupReleaseGroupResponse) -> Lookup<AlbumMeta> {
     Lookup {
         item: AlbumMeta {
-            id: entity.meta.title,
+            id: entity.meta.title.into(),
             date: entity.meta.first_release_date,
             seq: AlbumSeq::default(),
-            musicbrainz: MbRefOption::Some(entity.meta.id.into()),
-            primary_type: Some(entity.meta.primary_type),
-            secondary_types: entity.meta.secondary_types.unwrap_or_default(),
+            info: AlbumInfo {
+                musicbrainz: MbRefOption::Some(entity.meta.id.into()),
+                primary_type: Some(entity.meta.primary_type),
+                secondary_types: entity.meta.secondary_types.unwrap_or_default(),
+            },
         },
         disambiguation: None,
     }
 }
 
 fn from_search_artist_response_artist(entity: SearchArtistResponseArtist) -> Match<ArtistMeta> {
-    let sort: Option<ArtistId> = Some(entity.meta.sort_name)
-        .filter(|s| s != &entity.meta.name)
-        .map(Into::into);
+    let sort = Some(entity.meta.sort_name).filter(|s| s != &entity.meta.name);
     Match {
         score: entity.score,
         item: ArtistMeta {
-            id: entity.meta.name,
+            id: entity.meta.name.into(),
             sort,
-            musicbrainz: MbRefOption::Some(entity.meta.id.into()),
-            properties: HashMap::new(),
+            info: ArtistInfo {
+                musicbrainz: MbRefOption::Some(entity.meta.id.into()),
+                properties: HashMap::new(),
+            },
         },
         disambiguation: entity.meta.disambiguation,
     }
@@ -143,12 +145,14 @@ fn from_search_release_group_response_release_group(
     Match {
         score: entity.score,
         item: AlbumMeta {
-            id: entity.meta.title,
+            id: entity.meta.title.into(),
             date: entity.meta.first_release_date,
             seq: AlbumSeq::default(),
-            musicbrainz: MbRefOption::Some(entity.meta.id.into()),
-            primary_type: Some(entity.meta.primary_type),
-            secondary_types: entity.meta.secondary_types.unwrap_or_default(),
+            info: AlbumInfo {
+                musicbrainz: MbRefOption::Some(entity.meta.id.into()),
+                primary_type: Some(entity.meta.primary_type),
+                secondary_types: entity.meta.secondary_types.unwrap_or_default(),
+            },
         },
         disambiguation: None,
     }

src/tui/lib/external/musicbrainz/daemon/mod.rs

@@ -419,7 +419,7 @@ mod tests {
     }
 
     fn search_albums_requests() -> VecDeque<MbParams> {
-        let mbref = mb_ref_opt_as_ref(&COLLECTION[1].meta.musicbrainz);
+        let mbref = mb_ref_opt_as_ref(&COLLECTION[1].meta.info.musicbrainz);
         let arid = mb_ref_opt_unwrap(mbref).mbid().clone();
 
         let artist_id = COLLECTION[1].meta.id.clone();
@@ -437,7 +437,7 @@ mod tests {
     }
 
     fn album_arid_expectation() -> Mbid {
-        let mbref = mb_ref_opt_as_ref(&COLLECTION[1].meta.musicbrainz);
+        let mbref = mb_ref_opt_as_ref(&COLLECTION[1].meta.info.musicbrainz);
         mb_ref_opt_unwrap(mbref).mbid().clone()
     }
 

src/tui/lib/mod.rs

@@ -3,9 +3,8 @@ pub mod interface;
 
 use musichoard::{
     collection::{
-        album::{AlbumId, AlbumPrimaryType, AlbumSecondaryType},
-        artist::ArtistId,
-        musicbrainz::{MbAlbumRef, MbArtistRef, MbRefOption},
+        album::{AlbumId, AlbumInfo},
+        artist::{ArtistId, ArtistInfo},
         Collection,
     },
     interface::{database::IDatabase, library::ILibrary},
@@ -21,28 +20,13 @@ pub trait IMusicHoard {
     fn reload_database(&mut self) -> Result<(), musichoard::Error>;
     fn get_collection(&self) -> &Collection;
 
-    fn set_artist_musicbrainz(
-        &mut self,
-        id: &ArtistId,
-        mbref: MbRefOption<MbArtistRef>,
-    ) -> Result<(), musichoard::Error>;
-    fn set_album_musicbrainz(
+    fn set_artist_info(&mut self, id: &ArtistId, info: ArtistInfo)
+        -> Result<(), musichoard::Error>;
+    fn set_album_info(
         &mut self,
         artist_id: &ArtistId,
         album_id: &AlbumId,
-        mbref: MbRefOption<MbAlbumRef>,
-    ) -> Result<(), musichoard::Error>;
-    fn set_album_primary_type(
-        &mut self,
-        artist_id: &ArtistId,
-        album_id: &AlbumId,
-        primary_type: Option<AlbumPrimaryType>,
-    ) -> Result<(), musichoard::Error>;
-    fn set_album_secondary_types(
-        &mut self,
-        artist_id: &ArtistId,
-        album_id: &AlbumId,
-        secondary_types: Vec<AlbumSecondaryType>,
+        info: AlbumInfo,
     ) -> Result<(), musichoard::Error>;
 }
 
@@ -60,49 +44,21 @@ impl<Database: IDatabase, Library: ILibrary> IMusicHoard for MusicHoard<Database
         <Self as IMusicHoardBase>::get_collection(self)
     }
 
-    fn set_artist_musicbrainz(
+    fn set_artist_info(
         &mut self,
         id: &ArtistId,
-        mbref: MbRefOption<MbArtistRef>,
+        info: ArtistInfo,
     ) -> Result<(), musichoard::Error> {
-        <Self as IMusicHoardDatabase>::set_artist_musicbrainz(self, id, mbref)
+        <Self as IMusicHoardDatabase>::set_artist_info(self, id, info)
     }
 
-    fn set_album_musicbrainz(
+    fn set_album_info(
         &mut self,
         artist_id: &ArtistId,
         album_id: &AlbumId,
-        mbref: MbRefOption<MbAlbumRef>,
+        info: AlbumInfo,
     ) -> Result<(), musichoard::Error> {
-        <Self as IMusicHoardDatabase>::set_album_musicbrainz(self, artist_id, album_id, mbref)
-    }
-
-    fn set_album_primary_type(
-        &mut self,
-        artist_id: &ArtistId,
-        album_id: &AlbumId,
-        primary_type: Option<AlbumPrimaryType>,
-    ) -> Result<(), musichoard::Error> {
-        <Self as IMusicHoardDatabase>::set_album_primary_type(
-            self,
-            artist_id,
-            album_id,
-            primary_type,
-        )
-    }
-
-    fn set_album_secondary_types(
-        &mut self,
-        artist_id: &ArtistId,
-        album_id: &AlbumId,
-        secondary_types: Vec<AlbumSecondaryType>,
-    ) -> Result<(), musichoard::Error> {
-        <Self as IMusicHoardDatabase>::set_album_secondary_types(
-            self,
-            artist_id,
-            album_id,
-            secondary_types,
-        )
+        <Self as IMusicHoardDatabase>::set_album_info(self, artist_id, album_id, info)
     }
 }
 // GRCOV_EXCL_STOP

src/tui/testmod.rs

@@ -1,8 +1,8 @@
 use std::collections::HashMap;
 
 use musichoard::collection::{
-    album::{Album, AlbumId, AlbumMeta, AlbumPrimaryType, AlbumSeq},
-    artist::{Artist, ArtistId, ArtistMeta},
+    album::{Album, AlbumId, AlbumInfo, AlbumMeta, AlbumPrimaryType, AlbumSeq},
+    artist::{Artist, ArtistId, ArtistInfo, ArtistMeta},
     musicbrainz::{MbAlbumRef, MbArtistRef, MbRefOption},
     track::{Track, TrackFormat, TrackId, TrackNum, TrackQuality},
 };

src/tui/ui/browse_state.rs

@@ -169,7 +169,10 @@ impl<'a, 'b> AlbumState<'a, 'b> {
                 .map(|a| UiDisplay::display_date(&a.meta.date, &a.meta.seq))
                 .unwrap_or_default(),
             album
-                .map(|a| UiDisplay::display_type(&a.meta.primary_type, &a.meta.secondary_types))
+                .map(|a| UiDisplay::display_type(
+                    &a.meta.info.primary_type,
+                    &a.meta.info.secondary_types
+                ))
                 .unwrap_or_default(),
             album
                 .map(|a| UiDisplay::display_album_status(&a.get_status()))

src/tui/ui/display.rs

@@ -195,7 +195,7 @@ impl UiDisplay {
             "{:010} | {} [{}]",
             UiDisplay::display_album_date(&album.date),
             album.id.title,
-            UiDisplay::display_type(&album.primary_type, &album.secondary_types),
+            UiDisplay::display_type(&album.info.primary_type, &album.info.secondary_types),
         )
     }
 

src/tui/ui/info_state.rs

@@ -76,10 +76,10 @@ impl<'a> ArtistOverlay<'a> {
              Properties: {}",
             artist.map(|a| a.meta.id.name.as_str()).unwrap_or(""),
             artist
-                .map(|a| UiDisplay::display_mb_ref_option_as_url(&a.meta.musicbrainz))
+                .map(|a| UiDisplay::display_mb_ref_option_as_url(&a.meta.info.musicbrainz))
                 .unwrap_or_default(),
             Self::opt_hashmap_to_string(
-                artist.map(|a| &a.meta.properties),
+                artist.map(|a| &a.meta.info.properties),
                 &double_item_indent,
                 &double_list_indent
             ),
@@ -104,7 +104,7 @@ impl<'a> AlbumOverlay<'a> {
              MusicBrainz: {}",
             album.map(|a| a.meta.id.title.as_str()).unwrap_or(""),
             album
-                .map(|a| UiDisplay::display_mb_ref_option_as_url(&a.meta.musicbrainz))
+                .map(|a| UiDisplay::display_mb_ref_option_as_url(&a.meta.info.musicbrainz))
                 .unwrap_or_default(),
         ));
 

src/tui/ui/mod.rs

@@ -201,8 +201,9 @@ impl IUi for Ui {
 #[cfg(test)]
 mod tests {
     use musichoard::collection::{
-        album::{AlbumDate, AlbumId, AlbumMeta, AlbumPrimaryType, AlbumSecondaryType},
+        album::{AlbumDate, AlbumId, AlbumInfo, AlbumMeta, AlbumPrimaryType, AlbumSecondaryType},
         artist::{Artist, ArtistId, ArtistMeta},
+        musicbrainz::MbRefOption,
     };
 
     use crate::tui::{
@@ -381,8 +382,11 @@ mod tests {
         AlbumMeta::new(
             AlbumId::new("An Album"),
             AlbumDate::new(Some(1990), Some(5), None),
-            Some(AlbumPrimaryType::Album),
-            vec![AlbumSecondaryType::Live, AlbumSecondaryType::Compilation],
+            AlbumInfo::new(
+                MbRefOption::None,
+                Some(AlbumPrimaryType::Album),
+                vec![AlbumSecondaryType::Live, AlbumSecondaryType::Compilation],
+            ),
         )
     }
 

tests/testlib.rs

@@ -2,8 +2,8 @@ use once_cell::sync::Lazy;
 use std::collections::HashMap;
 
 use musichoard::collection::{
-    album::{Album, AlbumId, AlbumMeta, AlbumPrimaryType, AlbumSecondaryType, AlbumSeq},
-    artist::{Artist, ArtistId, ArtistMeta},
+    album::{Album, AlbumId, AlbumInfo, AlbumMeta, AlbumPrimaryType, AlbumSecondaryType, AlbumSeq},
+    artist::{Artist, ArtistId, ArtistInfo, ArtistMeta},
     musicbrainz::{MbArtistRef, MbRefOption},
     track::{Track, TrackFormat, TrackId, TrackNum, TrackQuality},
     Collection,
@@ -16,23 +16,23 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                 id: ArtistId {
                     name: String::from("Аркона"),
                 },
-                sort: Some(ArtistId{
-                    name: String::from("Arkona")
-                }),
-                musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
-                    "https://musicbrainz.org/artist/baad262d-55ef-427a-83c7-f7530964f212"
-                ).unwrap()),
-                properties: HashMap::from([
-                    (String::from("MusicButler"), vec![
-                        String::from("https://www.musicbutler.io/artist-page/283448581"),
+                sort: Some(String::from("Arkona")),
+                info: ArtistInfo {
+                    musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
+                        "https://musicbrainz.org/artist/baad262d-55ef-427a-83c7-f7530964f212"
+                    ).unwrap()),
+                    properties: HashMap::from([
+                        (String::from("MusicButler"), vec![
+                            String::from("https://www.musicbutler.io/artist-page/283448581"),
+                        ]),
+                        (String::from("Bandcamp"), vec![
+                            String::from("https://arkonamoscow.bandcamp.com/"),
+                        ]),
+                        (String::from("Qobuz"), vec![String::from(
+                            "https://www.qobuz.com/nl-nl/interpreter/arkona/download-streaming-albums",
+                        )]),
                     ]),
-                    (String::from("Bandcamp"), vec![
-                        String::from("https://arkonamoscow.bandcamp.com/"),
-                    ]),
-                    (String::from("Qobuz"), vec![String::from(
-                        "https://www.qobuz.com/nl-nl/interpreter/arkona/download-streaming-albums",
-                    )]),
-                ]),
+                },
             },
             albums: vec![Album {
                 meta: AlbumMeta {
@@ -41,9 +41,11 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                     },
                     date: 2011.into(),
                     seq: AlbumSeq(0),
-                    musicbrainz: MbRefOption::None,
-                    primary_type: Some(AlbumPrimaryType::Album),
-                    secondary_types: vec![],
+                    info: AlbumInfo {
+                        musicbrainz: MbRefOption::None,
+                        primary_type: Some(AlbumPrimaryType::Album),
+                        secondary_types: vec![],
+                    },
                 },
                 tracks: vec![
                     Track {
@@ -209,17 +211,19 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                     name: String::from("Eluveitie"),
                 },
                 sort: None,
-                musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
-                    "https://musicbrainz.org/artist/8000598a-5edb-401c-8e6d-36b167feaf38"
-                ).unwrap()),
-                properties: HashMap::from([
-                    (String::from("MusicButler"), vec![
-                        String::from("https://www.musicbutler.io/artist-page/269358403"),
+                info: ArtistInfo {
+                    musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
+                        "https://musicbrainz.org/artist/8000598a-5edb-401c-8e6d-36b167feaf38"
+                    ).unwrap()),
+                    properties: HashMap::from([
+                        (String::from("MusicButler"), vec![
+                            String::from("https://www.musicbutler.io/artist-page/269358403"),
+                        ]),
+                        (String::from("Qobuz"), vec![String::from(
+                            "https://www.qobuz.com/nl-nl/interpreter/eluveitie/download-streaming-albums",
+                        )]),
                     ]),
-                    (String::from("Qobuz"), vec![String::from(
-                        "https://www.qobuz.com/nl-nl/interpreter/eluveitie/download-streaming-albums",
-                    )]),
-                ]),
+                },
             },
             albums: vec![
                 Album {
@@ -229,9 +233,11 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                         },
                         date: 2004.into(),
                         seq: AlbumSeq(0),
-                        musicbrainz: MbRefOption::None,
-                        primary_type: Some(AlbumPrimaryType::Ep),
-                        secondary_types: vec![],
+                        info: AlbumInfo {
+                            musicbrainz: MbRefOption::None,
+                            primary_type: Some(AlbumPrimaryType::Ep),
+                            secondary_types: vec![],
+                        },
                     },
                     tracks: vec![
                         Track {
@@ -309,9 +315,11 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                         },
                         date: 2008.into(),
                         seq: AlbumSeq(0),
-                        musicbrainz: MbRefOption::None,
-                        primary_type: Some(AlbumPrimaryType::Album),
-                        secondary_types: vec![],
+                        info: AlbumInfo {
+                            musicbrainz: MbRefOption::None,
+                            primary_type: Some(AlbumPrimaryType::Album),
+                            secondary_types: vec![],
+                        },
                     },
                     tracks: vec![
                         Track {
@@ -456,17 +464,19 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                     name: String::from("Frontside"),
                 },
                 sort: None,
-                musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
-                    "https://musicbrainz.org/artist/3a901353-fccd-4afd-ad01-9c03f451b490"
-                ).unwrap()),
-                properties: HashMap::from([
-                    (String::from("MusicButler"), vec![
-                        String::from("https://www.musicbutler.io/artist-page/826588800"),
+                info: ArtistInfo {
+                    musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
+                        "https://musicbrainz.org/artist/3a901353-fccd-4afd-ad01-9c03f451b490"
+                    ).unwrap()),
+                    properties: HashMap::from([
+                        (String::from("MusicButler"), vec![
+                            String::from("https://www.musicbutler.io/artist-page/826588800"),
+                        ]),
+                        (String::from("Qobuz"), vec![String::from(
+                            "https://www.qobuz.com/nl-nl/interpreter/frontside/download-streaming-albums",
+                        )]),
                     ]),
-                    (String::from("Qobuz"), vec![String::from(
-                        "https://www.qobuz.com/nl-nl/interpreter/frontside/download-streaming-albums",
-                    )]),
-                ]),
+                },
             },
             albums: vec![Album {
                 meta: AlbumMeta {
@@ -475,9 +485,11 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                     },
                     date: 2001.into(),
                     seq: AlbumSeq(0),
-                    musicbrainz: MbRefOption::None,
-                    primary_type: Some(AlbumPrimaryType::Album),
-                    secondary_types: vec![],
+                    info: AlbumInfo {
+                        musicbrainz: MbRefOption::None,
+                        primary_type: Some(AlbumPrimaryType::Album),
+                        secondary_types: vec![],
+                    },
                 },
                 tracks: vec![
                     Track {
@@ -609,20 +621,20 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                 id: ArtistId {
                     name: String::from("Heaven’s Basement"),
                 },
-                sort: Some(ArtistId {
-                    name: String::from("Heaven’s Basement"),
-                }),
-                musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
-                    "https://musicbrainz.org/artist/c2c4d56a-d599-4a18-bd2f-ae644e2198cc"
-                ).unwrap()),
-                properties: HashMap::from([
-                    (String::from("MusicButler"), vec![
-                        String::from("https://www.musicbutler.io/artist-page/291158685"),
+                sort: Some(String::from("Heaven’s Basement")),
+                info: ArtistInfo {
+                    musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
+                        "https://musicbrainz.org/artist/c2c4d56a-d599-4a18-bd2f-ae644e2198cc"
+                    ).unwrap()),
+                    properties: HashMap::from([
+                        (String::from("MusicButler"), vec![
+                            String::from("https://www.musicbutler.io/artist-page/291158685"),
+                        ]),
+                        (String::from("Qobuz"), vec![String::from(
+                            "https://www.qobuz.com/nl-nl/interpreter/heaven-s-basement/download-streaming-albums",
+                        )]),
                     ]),
-                    (String::from("Qobuz"), vec![String::from(
-                        "https://www.qobuz.com/nl-nl/interpreter/heaven-s-basement/download-streaming-albums",
-                    )]),
-                ]),
+                },
             },
             albums: vec![Album {
                 meta: AlbumMeta {
@@ -631,9 +643,7 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                     },
                     date: 2011.into(),
                     seq: AlbumSeq(0),
-                    musicbrainz: MbRefOption::None,
-                    primary_type: None,
-                    secondary_types: vec![],
+                    info: AlbumInfo::default(),
                 },
                 tracks: vec![
                     Track {
@@ -655,9 +665,11 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                     },
                     date: 2011.into(),
                     seq: AlbumSeq(0),
-                    musicbrainz: MbRefOption::None,
-                    primary_type: Some(AlbumPrimaryType::Album),
-                    secondary_types: vec![],
+                    info: AlbumInfo {
+                        musicbrainz: MbRefOption::None,
+                        primary_type: Some(AlbumPrimaryType::Album),
+                        secondary_types: vec![],
+                    },
                 },
                 tracks: vec![
                     Track {
@@ -746,17 +758,19 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                     name: String::from("Metallica"),
                 },
                 sort: None,
-                musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
-                    "https://musicbrainz.org/artist/65f4f0c5-ef9e-490c-aee3-909e7ae6b2ab"
-                ).unwrap()),
-                properties: HashMap::from([
-                    (String::from("MusicButler"), vec![
-                        String::from("https://www.musicbutler.io/artist-page/3996865"),
+                info: ArtistInfo {
+                    musicbrainz: MbRefOption::Some(MbArtistRef::from_url_str(
+                        "https://musicbrainz.org/artist/65f4f0c5-ef9e-490c-aee3-909e7ae6b2ab"
+                    ).unwrap()),
+                    properties: HashMap::from([
+                        (String::from("MusicButler"), vec![
+                            String::from("https://www.musicbutler.io/artist-page/3996865"),
+                        ]),
+                        (String::from("Qobuz"), vec![String::from(
+                            "https://www.qobuz.com/nl-nl/interpreter/metallica/download-streaming-albums",
+                        )]),
                     ]),
-                    (String::from("Qobuz"), vec![String::from(
-                        "https://www.qobuz.com/nl-nl/interpreter/metallica/download-streaming-albums",
-                    )]),
-                ]),
+                },
             },
             albums: vec![
                 Album {
@@ -766,9 +780,11 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                         },
                         date: 1984.into(),
                         seq: AlbumSeq(0),
-                        musicbrainz: MbRefOption::None,
-                        primary_type: Some(AlbumPrimaryType::Album),
-                        secondary_types: vec![],
+                        info: AlbumInfo {
+                            musicbrainz: MbRefOption::None,
+                            primary_type: Some(AlbumPrimaryType::Album),
+                            secondary_types: vec![],
+                        },
                     },
                     tracks: vec![
                         Track {
@@ -868,9 +884,11 @@ pub static COLLECTION: Lazy<Vec<Artist>> = Lazy::new(|| -> Collection {
                         },
                         date: 1999.into(),
                         seq: AlbumSeq(0),
-                        musicbrainz: MbRefOption::None,
-                        primary_type: Some(AlbumPrimaryType::Album),
-                        secondary_types: vec![AlbumSecondaryType::Live],
+                        info: AlbumInfo {
+                            musicbrainz: MbRefOption::None,
+                            primary_type: Some(AlbumPrimaryType::Album),
+                            secondary_types: vec![AlbumSecondaryType::Live],
+                        },
                     },
                     tracks: vec![
                         Track {