From 34a250bd4288f0f6686bb581add334c11570c523 Mon Sep 17 00:00:00 2001
From: Wojciech Kozlowski <wk@wojciechkozlowski.eu>
Date: Sun, 22 Oct 2023 12:12:14 +0200
Subject: [PATCH] Tune netdata config

---
 system/extra/netdata/meta/argument_specs.yml | 10 ++++++++--
 system/extra/netdata/tasks/main.yml          | 10 ++++++++++
 system/extra/netdata/templates/netdata.conf  |  3 ++-
 3 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/system/extra/netdata/meta/argument_specs.yml b/system/extra/netdata/meta/argument_specs.yml
index 74bd1b9..2f560c0 100644
--- a/system/extra/netdata/meta/argument_specs.yml
+++ b/system/extra/netdata/meta/argument_specs.yml
@@ -2,15 +2,21 @@
 argument_specs:
   main:
     options:
+      system_extra_netdata_install_sensors:
+        type: "bool"
+        required: true
       system_extra_netdata_bind_to:
         type: "str"
-        required: true
+        required: false
+      system_extra_netdata_update_every:
+        type: "str"
+        required: false
       system_extra_netdata_stream_parent:
         type: "bool"
         required: true
       system_extra_netdata_stream_dest_inet6:
         type: "str"
-        required: true
+        required: "{{ not system_extra_netdata_stream_parent }}"
       system_extra_netdata_stream_api_key:
         type: "str"
         required: true
diff --git a/system/extra/netdata/tasks/main.yml b/system/extra/netdata/tasks/main.yml
index 25f110d..4e78fd6 100644
--- a/system/extra/netdata/tasks/main.yml
+++ b/system/extra/netdata/tasks/main.yml
@@ -6,6 +6,14 @@
       - "uuid-runtime"
   register: system_extra_netdata_install
 
+- name: "install lm-sensors"
+  ansible.builtin.apt:
+    name:
+      - "lm-sensors"
+  register: system_extra_netdata_lm_sensors_install
+  when:
+    system_extra_netdata_install_sensors
+
 - name: "enable netdata"
   ansible.builtin.systemd:
     name: "netdata"
@@ -41,6 +49,8 @@
     state: "restarted"
   when:
     (system_extra_netdata_install.changed or
+    (system_extra_netdata_lm_sensors_install is defined and
+    system_extra_netdata_lm_sensors_install.changed) or
     system_extra_netdata_netdata_conf.changed or
     system_extra_netdata_stream_conf.changed or
     system_extra_netdata_health_conf.changed) and
diff --git a/system/extra/netdata/templates/netdata.conf b/system/extra/netdata/templates/netdata.conf
index 551f316..a42541e 100644
--- a/system/extra/netdata/templates/netdata.conf
+++ b/system/extra/netdata/templates/netdata.conf
@@ -16,7 +16,8 @@
     web files group = root
     # Netdata is not designed to be exposed to potentially hostile
     # networks. See https://github.com/netdata/netdata/issues/164
-    bind socket to IP = {{ system_extra_netdata_bind_to }}
+    bind socket to IP = {{ system_extra_netdata_bind_to | default("localhost") }}
+    update every = {{ system_extra_netdata_update_every | default("1") }}
 
 [plugins]
     netdata monitoring = no